Re: [PATCH 4/6] bsg: add sg_io_v4 structure

[Jens Axboe <jens.axboe@oracle.com>]

On Fri, Dec 22 2006, FUJITA Tomonori wrote:
> From: Jens Axboe <jens.axboe@oracle.com>
> Subject: Re: [PATCH 4/6] bsg: add sg_io_v4 structure
> Date: Thu, 21 Dec 2006 08:28:23 +0100
> 
> > On Thu, Dec 21 2006, FUJITA Tomonori wrote:
> > > From: Jens Axboe <jens.axboe@oracle.com>
> > > Subject: Re: [PATCH 4/6] bsg: add sg_io_v4 structure
> > > Date: Wed, 20 Dec 2006 11:13:14 +0100
> > > 
> > > > On Wed, Dec 20 2006, FUJITA Tomonori wrote:
> > > > > This patch adds sg_io_v4 structure that Doug proposed last month.
> > > > > 
> > > > > There's one major change from the RFC. I dropped iovec, which needs
> > > > > compat stuff. The bsg code simply calls blk_rq_map_user against
> > > > > dout_xferp/din_xferp. So if possible, the page frames are directly
> > > > > mapped. If not possible, the block layer allocates new page frames and
> > > > > does memory copies.
> > > > > 
> > > > > Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> > > > > ---
> > > > >  include/linux/bsg.h |   43 +++++++++++++++++++++++++++++++++++++++++++
> > > > >  1 files changed, 43 insertions(+), 0 deletions(-)
> > > > > 
> > > > > diff --git a/include/linux/bsg.h b/include/linux/bsg.h
> > > > > index dc0d728..0d212cc 100644
> > > > > --- a/include/linux/bsg.h
> > > > > +++ b/include/linux/bsg.h
> > > > > @@ -1,6 +1,47 @@
> > > > >  #ifndef BSG_H
> > > > >  #define BSG_H
> > > > >  
> > > > > +struct sg_io_v4 {
> > > > > +	int32_t guard;		/* [i] 'Q' to differentiate from v3 */
> > > > > +	uint32_t protocol;	/* [i] 0 -> SCSI , .... */
> > > > 
> > > > I prefer using the u32 types and so on for explicitly sized variables.
> > > > I'll make that change.
> > > 
> > > I see though we need to use __u32 instead of u32, don't we?
> > 
> > Yep, we should.
> 
> Are you waiting for a patch?

Not really, just didn't get to it yet. But I'll take the patch, thanks
:-)

Could you do the __user annotations as well?

-- 
Jens Axboe