From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 4/6] bsg: add sg_io_v4 structure Date: Fri, 22 Dec 2006 09:42:24 +0100 Message-ID: <20061222084224.GM17199@kernel.dk> References: <20061220101314.GL5010@kernel.dk> <20061221072942N.fujita.tomonori@lab.ntt.co.jp> <20061221072809.GM10535@kernel.dk> <20061222134635M.fujita.tomonori@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from brick.kernel.dk ([62.242.22.158]:14301 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1945986AbWLVIkb (ORCPT ); Fri, 22 Dec 2006 03:40:31 -0500 Content-Disposition: inline In-Reply-To: <20061222134635M.fujita.tomonori@lab.ntt.co.jp> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: FUJITA Tomonori Cc: linux-scsi@vger.kernel.org, dougg@torque.net On Fri, Dec 22 2006, FUJITA Tomonori wrote: > From: Jens Axboe > Subject: Re: [PATCH 4/6] bsg: add sg_io_v4 structure > Date: Thu, 21 Dec 2006 08:28:23 +0100 > > > On Thu, Dec 21 2006, FUJITA Tomonori wrote: > > > From: Jens Axboe > > > Subject: Re: [PATCH 4/6] bsg: add sg_io_v4 structure > > > Date: Wed, 20 Dec 2006 11:13:14 +0100 > > > > > > > On Wed, Dec 20 2006, FUJITA Tomonori wrote: > > > > > This patch adds sg_io_v4 structure that Doug proposed last month. > > > > > > > > > > There's one major change from the RFC. I dropped iovec, which needs > > > > > compat stuff. The bsg code simply calls blk_rq_map_user against > > > > > dout_xferp/din_xferp. So if possible, the page frames are directly > > > > > mapped. If not possible, the block layer allocates new page frames and > > > > > does memory copies. > > > > > > > > > > Signed-off-by: FUJITA Tomonori > > > > > --- > > > > > include/linux/bsg.h | 43 +++++++++++++++++++++++++++++++++++++++++++ > > > > > 1 files changed, 43 insertions(+), 0 deletions(-) > > > > > > > > > > diff --git a/include/linux/bsg.h b/include/linux/bsg.h > > > > > index dc0d728..0d212cc 100644 > > > > > --- a/include/linux/bsg.h > > > > > +++ b/include/linux/bsg.h > > > > > @@ -1,6 +1,47 @@ > > > > > #ifndef BSG_H > > > > > #define BSG_H > > > > > > > > > > +struct sg_io_v4 { > > > > > + int32_t guard; /* [i] 'Q' to differentiate from v3 */ > > > > > + uint32_t protocol; /* [i] 0 -> SCSI , .... */ > > > > > > > > I prefer using the u32 types and so on for explicitly sized variables. > > > > I'll make that change. > > > > > > I see though we need to use __u32 instead of u32, don't we? > > > > Yep, we should. > > Are you waiting for a patch? Not really, just didn't get to it yet. But I'll take the patch, thanks :-) Could you do the __user annotations as well? -- Jens Axboe