From: Matthew Wilcox <matthew@wil.cx>
To: Douglas Gilbert <dougg@torque.net>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux1394-devel@lists.sourceforge.net,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] ieee1394: sbp2: pass REQUEST_SENSE through to the target
Date: Thu, 28 Dec 2006 13:54:06 -0700 [thread overview]
Message-ID: <20061228205406.GC20153@parisc-linux.org> (raw)
In-Reply-To: <45942759.8080804@torque.net>
On Thu, Dec 28, 2006 at 03:21:45PM -0500, Douglas Gilbert wrote:
> So, this patch is a step in the right direction.
> Hopefully not too many other LLDs are playing
> games with REQUEST SENSE.
A lot of drivers play games with REQUEST_SENSE, but they mostly seem to
be doing things with their own internal state. One suspicious one is
BusLogic.c :
/*
SCSI REQUEST_SENSE commands will be executed automatically by the Host
Adapter for any errors, so they should not be executed explicitly unless
the Sense Data is zero indicating that no error occurred.
*/
if (CDB[0] == REQUEST_SENSE && Command->sense_buffer[0] != 0) {
Command->result = DID_OK << 16;
CompletionRoutine(Command);
return 0;
}
I don't know if this is OK for your scenario or not.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
next prev parent reply other threads:[~2006-12-28 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-28 18:57 [PATCH] ieee1394: sbp2: pass REQUEST_SENSE through to the target Stefan Richter
2006-12-28 20:21 ` Douglas Gilbert
2006-12-28 20:54 ` Matthew Wilcox [this message]
2006-12-28 22:38 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061228205406.GC20153@parisc-linux.org \
--to=matthew@wil.cx \
--cc=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox