From: Christoph Hellwig <hch@infradead.org>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-scsi@vger.kernel.org, dougg@torque.net, jens.axboe@oracle.com
Subject: Re: [PATCH 1/3] block: export blk_verify_command for SG v4
Date: Tue, 2 Jan 2007 11:49:16 +0000 [thread overview]
Message-ID: <20070102114916.GC24951@infradead.org> (raw)
In-Reply-To: <20061216001756S.fujita.tomonori@lab.ntt.co.jp>
On Sat, Dec 16, 2006 at 12:18:23AM +0900, FUJITA Tomonori wrote:
> blk_fill_sghdr_rq doesn't work for SG v4 so verify_command needed to
> be exported.
So fixup blk_fill_sghdr_rq to deal with SG v4 aswell. We really
need to support all SGv4 features in the core code - bsg should
only be a small wrapper around core functionality at the end.
And while you're touching this code, is there any chance you could
unifity the command permission tables for the block layer code and
the sg driver? This has been long overdue.
doug has a nice document somewhere that documents the differences
between command allowances for the block layer vs the sg driver.
Please go through these and take the more resonable version for
each command.
next prev parent reply other threads:[~2007-01-02 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-15 15:18 [PATCH 1/3] block: export blk_verify_command for SG v4 FUJITA Tomonori
2007-01-02 11:49 ` Christoph Hellwig [this message]
2007-01-02 15:02 ` FUJITA Tomonori
2007-01-02 15:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070102114916.GC24951@infradead.org \
--to=hch@infradead.org \
--cc=dougg@torque.net \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox