Re: struct request members, etc..

[Jens Axboe <jens.axboe@oracle.com>]

On Tue, Jan 02 2007, Christoph Hellwig wrote:
> On Tue, Jan 02, 2007 at 01:34:18PM +0100, Jens Axboe wrote:
> > On Tue, Jan 02 2007, Christoph Hellwig wrote:
> > > This gets a little offtopic for the original issue, so let's cut the Cc
> > > list and change the subject.
> > > 
> > > On Tue, Dec 12, 2006 at 04:21:23PM +0200, Boaz Harrosh wrote:
> > > > I'm afraid this might not be enough because of code in drivers/ide/ide-cd.c. It does IO off of request->data.
> > > 
> > > Only for FS requests, but we do BLOCK_PC requests here.
> > 
> > ->buffer is the old style FS requests, ->data is never used for FS
> > requests. BLOCK_PC requests should use just ->data, but I would not be
> > surprised if ide-cd and others still map it to ->buffer.
> 
> Actually after my last patch BLOCK_PC request should use neither.
> Nowdays if a BLOCK_PC requests wants to transfer data it must
> use req->bio.

Cool, just worrying that it might complicate some drivers. ide-cd itself
should actually be cleaned up, as we can drop one of the old pc
interrupt handlers as well.

-- 
Jens Axboe