Re: [2.6 patch] SCSI seagate.c: remove SEAGATE_USE_ASM

Adrian Bunk
2007-01-22T15:38:08Z

On Mon, Jan 22, 2007 at 03:18:41PM +0000, Alan wrote:
> On Sun, 21 Jan 2007 20:13:00 +0100
> Adrian Bunk <bunk@stusta.de> wrote:
>
> > Using assembler code for performance in drivers might have been a good
> > idea 15 years ago when this code was written, but with today's compilers
> > that's unlikely to be an advantage.
> >
> > Besides this, it also hurts the readability.
> >
> > Simply use the C code that was already there as an alternative.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> "stosb\n\t"
>
> NAK
>
> The C codepaths are essentially untested on this driver.

Has any part of this driver ever be tested with kernel 2.6?
Or compiled with gcc 4?

> Alan

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed