From: Andrew Morton <akpm@linux-foundation.org>
To: Sumant Patro <sumantp@lsil.com>
Cc: James.Bottomley@SteelEye.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, neela.kolli@lsi.com,
bo.yang@lsi.com, sumant.patro@lsi.com
Subject: Re: [PATCH 1/5] scsi: megaraid_sas - stop cmd processing if hw_crit_error is set
Date: Wed, 7 Feb 2007 13:17:53 -0800 [thread overview]
Message-ID: <20070207131753.1b631421.akpm@linux-foundation.org> (raw)
In-Reply-To: <1170798564.10482.12.camel@dumbo>
On Tue, 06 Feb 2007 13:49:24 -0800
Sumant Patro <sumantp@lsil.com> wrote:
> + /* Don't process if we have already declared adapter dead */
> + if(instance->hw_crit_error)
Preferred kernel coding style is "if (".
> [p1-crit_err.patch text/x-patch (1.3KB)]
argh. Please don't send two copies of the patch in the email. Because the
result applies happily with `patch --dry-run' and then creates a great mess
when you try to apply the patch for real.
next prev parent reply other threads:[~2007-02-07 21:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 21:49 [PATCH 1/5] scsi: megaraid_sas - stop cmd processing if hw_crit_error is set Sumant Patro
2007-02-07 21:17 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-02-08 2:59 Patro, Sumant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070207131753.1b631421.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@SteelEye.com \
--cc=bo.yang@lsi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=neela.kolli@lsi.com \
--cc=sumant.patro@lsi.com \
--cc=sumantp@lsil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox