From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH]indistinguishable devices with broken and unbroken firmware Date: Wed, 7 Feb 2007 15:05:55 +0000 Message-ID: <20070207150555.GA7054@infradead.org> References: <200702071522.39529.oneukum@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:39409 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161353AbXBGPGH (ORCPT ); Wed, 7 Feb 2007 10:06:07 -0500 Content-Disposition: inline In-Reply-To: <200702071522.39529.oneukum@suse.de> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Oliver Neukum Cc: usb-storage@lists.one-eyed-alien.net, linux-scsi@vger.kernel.org On Wed, Feb 07, 2007 at 03:22:39PM +0100, Oliver Neukum wrote: > Hi, > > there's a USB mass storage device which exists in two version. One > reports the correct size and the other does not. Apart from that they > are identical and cannot be told apart. Here's a heuristic based on the > empirical finding that drives have even sizes. I know it's ugly, but it fixes > an ugly bug. Do we really need a second flag? Alternatively fix_capacity could be changed to mean fix size if odd.