From: Oliver Neukum <oneukum@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: usb-storage@lists.one-eyed-alien.net, linux-scsi@vger.kernel.org
Subject: Re: [PATCH]indistinguishable devices with broken and unbroken firmware
Date: Wed, 7 Feb 2007 16:16:55 +0100 [thread overview]
Message-ID: <200702071616.55419.oneukum@suse.de> (raw)
In-Reply-To: <20070207150555.GA7054@infradead.org>
Am Mittwoch, 7. Februar 2007 16:05 schrieb Christoph Hellwig:
> On Wed, Feb 07, 2007 at 03:22:39PM +0100, Oliver Neukum wrote:
> > Hi,
> >
> > there's a USB mass storage device which exists in two version. One
> > reports the correct size and the other does not. Apart from that they
> > are identical and cannot be told apart. Here's a heuristic based on the
> > empirical finding that drives have even sizes. I know it's ugly, but it fixes
> > an ugly bug.
>
> Do we really need a second flag? Alternatively fix_capacity could be
> changed to mean fix size if odd.
Until we learn about devices which really do have an odd number of sectors.
And then we'll have a problem. I'd like to avoid heuristics when we know
for sure.
Regards
Oliver
next prev parent reply other threads:[~2007-02-07 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-07 14:22 [PATCH]indistinguishable devices with broken and unbroken firmware Oliver Neukum
2007-02-07 15:05 ` Christoph Hellwig
2007-02-07 15:16 ` Oliver Neukum [this message]
2007-02-07 18:42 ` [usb-storage] " Alan Stern
2007-02-07 18:40 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702071616.55419.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox