From: Joe Jin <joe.jin@oracle.com>
To: akpm@osdl.org, dgilbert@interlog.com, James.Bottomley@SteelEye.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
haobo.zhou@oracle.com
Subject: [PATCH] [scsi]: Add offline state checking while dispatch a scsi cmd
Date: Thu, 8 Mar 2007 17:22:07 +0800 [thread overview]
Message-ID: <20070308092207.GA17141@joejin-pc.cn.oracle.com> (raw)
While a scsi device hw error occured, device's status maybe setting
to SDEV_OFFLINE, So at scsi_dispatch_cmd function, we should checking
if device have offline, if yes, do nothing and just return error to
user directly.
Signed-off-by: Joe Jin <lkmaillist@gmail.com>
--
--- linux-2.6.21-rc2/drivers/scsi/scsi.c.orig 2007-03-08 16:50:14.000000000 +0800
+++ linux-2.6.21-rc2/drivers/scsi/scsi.c 2007-03-08 16:52:45.000000000 +0800
@@ -486,10 +486,12 @@
int rtn = 0;
/* check if the device is still usable */
- if (unlikely(cmd->device->sdev_state == SDEV_DEL)) {
- /* in SDEV_DEL we error all commands. DID_NO_CONNECT
- * returns an immediate error upwards, and signals
- * that the device is no longer present */
+ if (unlikely(cmd->device->sdev_state == SDEV_DEL ||
+ cmd->device->sdev_state == SDEV_OFFLINE)) {
+ /* in SDEV_DEL or SDEV_OFFLINE we error all commands.
+ * DID_NO_CONNECT returns an immediate error upwards,
+ * and signals that the device is no longer present
+ */
cmd->result = DID_NO_CONNECT << 16;
atomic_inc(&cmd->device->iorequest_cnt);
__scsi_done(cmd);
next reply other threads:[~2007-03-08 9:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-08 9:22 Joe Jin [this message]
2007-03-08 16:02 ` [PATCH] [scsi]: Add offline state checking while dispatch a scsi cmd James Bottomley
2007-03-09 1:40 ` Joe Jin
2007-03-11 9:53 ` Andrew Morton
2007-03-12 2:52 ` Joe Jin
2007-03-12 3:15 ` Andrew Morton
2007-03-11 15:21 ` James Bottomley
2007-03-12 1:03 ` Joe Jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070308092207.GA17141@joejin-pc.cn.oracle.com \
--to=joe.jin@oracle.com \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=dgilbert@interlog.com \
--cc=haobo.zhou@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox