* drivers/message/fusion/mptsas.c: inconsequent NULL checking
@ 2007-03-19 9:24 Adrian Bunk
0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2007-03-19 9:24 UTC (permalink / raw)
To: Eric.Moore; +Cc: mpt_linux_developer, linux-scsi, linux-kernel
The Coverity checker spotted the following inconsequent NULL checking in
drivers/message/fusion/mptsas.c:
<-- snip -->
...
static void
mptsas_delete_expander_phys(MPT_ADAPTER *ioc)
{
...
if (port_info->phy_info &&
(!(port_info->phy_info[0].identify.device_info &
MPI_SAS_DEVICE_INFO_SMP_TARGET)))
continue;
if (mptsas_sas_expander_pg0(ioc, &buffer,
(MPI_SAS_EXPAND_PGAD_FORM_HANDLE <<
MPI_SAS_EXPAND_PGAD_FORM_SHIFT),
port_info->phy_info[0].handle)) {
...
<-- snip -->
port_info->phy_info is first checked but later dereferenced
unconditionally.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-03-19 9:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-19 9:24 drivers/message/fusion/mptsas.c: inconsequent NULL checking Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).