Re: some PCMCIA SCSI drivers can be built *only* as modules

Re: some PCMCIA SCSI drivers can be built *only* as modules

[Stefan Richter]

Robert P. J. Day wrote at LKML:
> drivers/scsi/pcmcia/Kconfig:
> ...
> config PCMCIA_AHA152X
>         tristate "Adaptec AHA152X PCMCIA support"
>         depends on m && !64BIT
>         select SCSI_SPI_ATTRS
>         help
>           Say Y here if you intend to attach this type of PCMCIA SCSI host
>           adapter to your computer.
> 
>           To compile this driver as a module, choose M here: the
>           module will be called aha152x_cs.
> ...
> 
>   it would seem to make no sense that the "depends on" clause for this
> option includes "m", forcing this (and all other four entries in that
> Kconfig file, by the way) to be built as modules, while the help text
> for all five entries suggests you can select "y".
> 
>   as jack nicholson would say, something's gotta give.

LSML a.k.a. linux-scsi may know what's gotta give.
-- 
Stefan Richter
-=====-=-=== --== ==-=-
http://arcgraph.de/sr/

Re: some PCMCIA SCSI drivers can be built *only* as modules

[Christoph Hellwig]

> >   it would seem to make no sense that the "depends on" clause for this
> > option includes "m", forcing this (and all other four entries in that
> > Kconfig file, by the way) to be built as modules, while the help text
> > for all five entries suggests you can select "y".

In the old days pcmcia drivers had to be modular because pcmcia required
a lot of userspace setup.  It's not needed anymore these days and the
dependencies can go.

Re: some PCMCIA SCSI drivers can be built *only* as modules

[Robert P. J. Day]

On Mon, 26 Mar 2007, Christoph Hellwig wrote:

> > >   it would seem to make no sense that the "depends on" clause
> > > for this option includes "m", forcing this (and all other four
> > > entries in that Kconfig file, by the way) to be built as
> > > modules, while the help text for all five entries suggests you
> > > can select "y".
>
> In the old days pcmcia drivers had to be modular because pcmcia
> required a lot of userspace setup.  It's not needed anymore these
> days and the dependencies can go.

i'd suspected something along those lines, which is why i submitted
the patch below to the LKML just a while ago.  if anyone wants to pick
it up and apply it somewhere, feel free.

(i dropped the LKML from the CC list, i don't think they need to see
any more of this.)



diff --git a/drivers/scsi/pcmcia/Kconfig b/drivers/scsi/pcmcia/Kconfig
index eac8e17..7dd787f 100644
--- a/drivers/scsi/pcmcia/Kconfig
+++ b/drivers/scsi/pcmcia/Kconfig
@@ -3,11 +3,11 @@
 #

 menu "PCMCIA SCSI adapter support"
-	depends on SCSI!=n && PCMCIA!=n && MODULES
+	depends on SCSI!=n && PCMCIA!=n

 config PCMCIA_AHA152X
 	tristate "Adaptec AHA152X PCMCIA support"
-	depends on m && !64BIT
+	depends on !64BIT
 	select SCSI_SPI_ATTRS
 	help
 	  Say Y here if you intend to attach this type of PCMCIA SCSI host
@@ -18,7 +18,6 @@ config PCMCIA_AHA152X

 config PCMCIA_FDOMAIN
 	tristate "Future Domain PCMCIA support"
-	depends on m
 	help
 	  Say Y here if you intend to attach this type of PCMCIA SCSI host
 	  adapter to your computer.
@@ -28,7 +27,7 @@ config PCMCIA_FDOMAIN

 config PCMCIA_NINJA_SCSI
 	tristate "NinjaSCSI-3 / NinjaSCSI-32Bi (16bit) PCMCIA support"
-	depends on m && !64BIT
+	depends on !64BIT
 	help
 	  If you intend to attach this type of PCMCIA SCSI host adapter to
 	  your computer, say Y here and read
@@ -62,7 +61,6 @@ config PCMCIA_NINJA_SCSI

 config PCMCIA_QLOGIC
 	tristate "Qlogic PCMCIA support"
-	depends on m
 	help
 	  Say Y here if you intend to attach this type of PCMCIA SCSI host
 	  adapter to your computer.
@@ -72,7 +70,6 @@ config PCMCIA_QLOGIC

 config PCMCIA_SYM53C500
 	tristate "Symbios 53c500 PCMCIA support"
-	depends on m
 	help
 	  Say Y here if you have a New Media Bus Toaster or other PCMCIA
 	  SCSI adapter based on the Symbios 53c500 controller.

Re: some PCMCIA SCSI drivers can be built *only* as modules

[Stefan Richter]

On 26 Mar, Robert P. J. Day wrote:
> On Mon, 26 Mar 2007, Christoph Hellwig wrote:
>> In the old days pcmcia drivers had to be modular because pcmcia
>> required a lot of userspace setup.  It's not needed anymore these
>> days and the dependencies can go.
> 
> i'd suspected something along those lines, which is why i submitted
> the patch below to the LKML just a while ago.  if anyone wants to pick
> it up and apply it somewhere, feel free.

James,
maybe you want to take it since it's for drivers/scsi/pcmcia/Kconfig.


Date: Sun, 25 Mar 2007 13:59:36 -0400 (EDT)
From: "Robert P. J. Day" <rpjday@mindspring.com>
Subject: [PATCH] PCMCIA: Allow PCMCIA SCSI drivers to be built into the kernel.

Remove the Kconfig requirement that the PCMCIA SCSI drivers be built
only as modules, and allow them to be built into the kernel.

Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

---

i imagine there's a historical reason for these drivers being forced
to be built only as modules.  and i'm not sure whether i should have
CCed the SCSI folks, the PCMCIA folks, or both.  or whatever.

compile-tested on x86 with "make allyesconfig".

diff --git a/drivers/scsi/pcmcia/Kconfig b/drivers/scsi/pcmcia/Kconfig
index eac8e17..7dd787f 100644
--- a/drivers/scsi/pcmcia/Kconfig
+++ b/drivers/scsi/pcmcia/Kconfig
@@ -3,11 +3,11 @@
 #

 menu "PCMCIA SCSI adapter support"
-	depends on SCSI!=n && PCMCIA!=n && MODULES
+	depends on SCSI!=n && PCMCIA!=n

 config PCMCIA_AHA152X
 	tristate "Adaptec AHA152X PCMCIA support"
-	depends on m && !64BIT
+	depends on !64BIT
 	select SCSI_SPI_ATTRS
 	help
 	  Say Y here if you intend to attach this type of PCMCIA SCSI host
@@ -18,7 +18,6 @@ config PCMCIA_AHA152X

 config PCMCIA_FDOMAIN
 	tristate "Future Domain PCMCIA support"
-	depends on m
 	help
 	  Say Y here if you intend to attach this type of PCMCIA SCSI host
 	  adapter to your computer.
@@ -28,7 +27,7 @@ config PCMCIA_FDOMAIN

 config PCMCIA_NINJA_SCSI
 	tristate "NinjaSCSI-3 / NinjaSCSI-32Bi (16bit) PCMCIA support"
-	depends on m && !64BIT
+	depends on !64BIT
 	help
 	  If you intend to attach this type of PCMCIA SCSI host adapter to
 	  your computer, say Y here and read
@@ -62,7 +61,6 @@ config PCMCIA_NINJA_SCSI

 config PCMCIA_QLOGIC
 	tristate "Qlogic PCMCIA support"
-	depends on m
 	help
 	  Say Y here if you intend to attach this type of PCMCIA SCSI host
 	  adapter to your computer.
@@ -72,7 +70,6 @@ config PCMCIA_QLOGIC

 config PCMCIA_SYM53C500
 	tristate "Symbios 53c500 PCMCIA support"
-	depends on m
 	help
 	  Say Y here if you have a New Media Bus Toaster or other PCMCIA
 	  SCSI adapter based on the Symbios 53c500 controller.

Re: some PCMCIA SCSI drivers can be built *only* as modules

[James Bottomley]

On Mon, 2007-03-26 at 21:02 +0100, Christoph Hellwig wrote:
> > >   it would seem to make no sense that the "depends on" clause for this
> > > option includes "m", forcing this (and all other four entries in that
> > > Kconfig file, by the way) to be built as modules, while the help text
> > > for all five entries suggests you can select "y".
> 
> In the old days pcmcia drivers had to be modular because pcmcia required
> a lot of userspace setup.  It's not needed anymore these days and the
> dependencies can go.

I agree the non-legacy (CardBus and beyond) ones can be built in.  I
thought the legacy 8 and 16 bit type I and II still had to be modular
because they still need setting up.

James

Re: some PCMCIA SCSI drivers can be built *only* as modules

[Christoph Hellwig]

On Mon, Mar 26, 2007 at 03:35:47PM -0500, James Bottomley wrote:
> I agree the non-legacy (CardBus and beyond) ones can be built in.  I
> thought the legacy 8 and 16 bit type I and II still had to be modular
> because they still need setting up.

nope.  While I don't have a pcmcia scsi card my 16 bit pcmcia wireless
cards work perfectly fine without any previous setup.

Re: some PCMCIA SCSI drivers can be built *only* as modules

[James Bottomley]

On Mon, 2007-03-26 at 21:38 +0100, Christoph Hellwig wrote:
> On Mon, Mar 26, 2007 at 03:35:47PM -0500, James Bottomley wrote:
> > I agree the non-legacy (CardBus and beyond) ones can be built in.  I
> > thought the legacy 8 and 16 bit type I and II still had to be modular
> > because they still need setting up.
> 
> nope.  While I don't have a pcmcia scsi card my 16 bit pcmcia wireless
> cards work perfectly fine without any previous setup.

OK ... I had the opposite experience ... A ZoomAir 802.11b card wasn't
working because I'd accidentally config'd it non-modular.  However, if
Dominik confirms it's all supposed to work non-modular, I'm happy to
conclude my experience was pilot error.

James

Re: some PCMCIA SCSI drivers can be built *only* as modules

[Dominik Brodowski]

On Mon, Mar 26, 2007 at 04:06:53PM -0500, James Bottomley wrote:
> On Mon, 2007-03-26 at 21:38 +0100, Christoph Hellwig wrote:
> > On Mon, Mar 26, 2007 at 03:35:47PM -0500, James Bottomley wrote:
> > > I agree the non-legacy (CardBus and beyond) ones can be built in.  I
> > > thought the legacy 8 and 16 bit type I and II still had to be modular
> > > because they still need setting up.
> > 
> > nope.  While I don't have a pcmcia scsi card my 16 bit pcmcia wireless
> > cards work perfectly fine without any previous setup.
> 
> OK ... I had the opposite experience ... A ZoomAir 802.11b card wasn't
> working because I'd accidentally config'd it non-modular.  However, if
> Dominik confirms it's all supposed to work non-modular.

PCMCIA card drivers should (famous last words) work just fine if built as
modules. They may not be bound to devices, depending on the arch and 
system, until userspace tools have run, but this is independent of modular
or built-in drivers. So a full ACK on this.

Thanks,

Dominik