[PATCH] aacraid: Panics during init time reset (Was: [PATCH] aacraid: [Fastboot] Panics for AACRAID driver during 'insmod' for kexec test)

Salyzyn, Mark
2007-04-02T18:34:39Z

[-- Attachment #1: Type: text/plain, Size: 738 bytes --]

Duane discovered in the scsi-misc-2.6 code that the reset handler could
be called without the sync command handler set up resulting in a panic.
Judith discovered this issue within minutes and has recently reported
it. Here is a fix.

IMHO, this needs to be applied immediately regardless of the status of
the kexec patch as this issue is present in the scsi-misc-2.6 driver for
all existing init-time recovery actions. This patch in principal would
not be different w/o the kexec patch.

ObligatoryDisclaimer: Please accept my condolences regarding Outlook's
handling of patches.

This attached patch is against current scsi-misc-2.6

Signed-off-by: Mark Salyzyn <aacraid@adaptec.com>

---

Sincerely -- Mark Salyzyn

[-- Attachment #2: aacraid_kexec_2.patch --]
[-- Type: application/octet-stream, Size: 461 bytes --]

diff -ru a/drivers/scsi/aacraid/rx.c b/drivers/scsi/aacraid/rx.c
--- a/drivers/scsi/aacraid/rx.c 2007-04-02 14:13:09.430198732 -0400
+++ b/drivers/scsi/aacraid/rx.c 2007-04-02 14:13:09.000000000 -0400
@@ -539,6 +543,7 @@
}

/* Failure to reset here is an option ... */
+ dev->a_ops.adapter_sync_cmd = rx_sync_cmd;
dev->OIMR = status = rx_readb (dev, MUnit.OIMR);
if ((((status & 0xff) != 0xff) || reset_devices) &&
!aac_rx_restart_adapter(dev, 0))