From: Matthew Wilcox <matthew@wil.cx>
To: brking@linux.vnet.ibm.com
Cc: James.Bottomley@steeleye.com, linux-scsi@vger.kernel.org
Subject: Re: [patch 1/1] scsi: Disable short inquiry log by default
Date: Mon, 2 Apr 2007 15:35:39 -0600 [thread overview]
Message-ID: <20070402213539.GI826@parisc-linux.org> (raw)
In-Reply-To: <200704022120.l32LKOZU018499@d03av02.boulder.ibm.com>
On Mon, Apr 02, 2007 at 04:20:22PM -0500, brking@linux.vnet.ibm.com wrote:
> if (sdev->inquiry_len < 36) {
> - printk(KERN_INFO "scsi scan: INQUIRY result too short (%d),"
> - " using 36\n", sdev->inquiry_len);
> + SCSI_LOG_SCAN_BUS(1, printk(KERN_INFO "scsi scan: INQUIRY result too"
> + " short (%d), using 36\n", sdev->inquiry_len));
> sdev->inquiry_len = 36;
The wrapping's a bit awkward. How about:
+ SCSI_LOG_SCAN_BUS(1, printk(KERN_INFO "scsi scan: INQUIRY "
+ "result too short (%d), using 36\n",
+ sdev->inquiry_len);
next prev parent reply other threads:[~2007-04-02 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-02 21:20 [patch 1/1] scsi: Disable short inquiry log by default brking
2007-04-02 21:35 ` Matthew Wilcox [this message]
2007-04-02 21:42 ` James Bottomley
2007-04-04 18:18 ` Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070402213539.GI826@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@steeleye.com \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox