From: Christoph Hellwig <hch@infradead.org>
To: Olaf Kirch <okir@lst.de>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] fill in scsi_host_template module owner
Date: Mon, 30 Apr 2007 17:02:33 +0100 [thread overview]
Message-ID: <20070430160233.GA27438@infradead.org> (raw)
In-Reply-To: <200704301653.56687.okir@lst.de>
On Mon, Apr 30, 2007 at 04:53:55PM +0200, Olaf Kirch wrote:
> I recently ran into an oops that happens because you
> can shut down all of iSCSI even though you still have
> iSCSI targets mounted. It turned out that iscsi's
> scsi_host_template missed a THIS_MODULE, so
> reference counting wasn't done properly. Brief
> inspection showed that this seems to be a rather
> wide-spread problem. Here's a patch to address this.
Two comments:
- a driver should handle hot unplugs proper, even if THIS_MODULE
is set this can happen if the hardware just goes away.
- strictly speaking many of the drivers in your patch already set
up the owner because scsi_module.c already does it for them.
But we try to get rid of scsi_module.c so this is an improvement,
you can now remove setting .module in scsi_module.c
next prev parent reply other threads:[~2007-04-30 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-30 14:53 [PATCH] fill in scsi_host_template module owner Olaf Kirch
2007-04-30 16:02 ` Christoph Hellwig [this message]
2007-05-02 8:07 ` Olaf Kirch
2007-05-02 8:37 ` Christoph Hellwig
2007-05-07 18:25 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070430160233.GA27438@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=okir@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox