From: Christoph Hellwig <hch@infradead.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-scsi@vger.kernel.org,
James Bottomley <James.Bottomley@steeleye.com>
Subject: Re: [PATCH 2/3] tmscsim: remove bogus endianness conversions
Date: Sat, 5 May 2007 10:37:51 +0100 [thread overview]
Message-ID: <20070505093751.GB9422@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.60.0705042257410.21060@poirot.grange>
On Fri, May 04, 2007 at 10:59:40PM +0200, Guennadi Liakhovetski wrote:
> cpu_to_le32 endianness conversions in tmscsim.c, followed by
> arithmetic operations don't look correct. Besides, {in,out}[wl]
> already perform the necessary conversions. Further, bus addresses
> of request buffers are guaranteed to be (mapped) under 4G by
> current scsi- and block-layer defaults. This could be explicitly
> enforced by using blk_queue_bounce_limit(), which, however,
> doesn't seem to be the common practice among SCSI drivers.
Looks good to me. If there are structures in dma memory in the driver
it would help to give the __le annotation to get the whole endianess
handling completely right.
next prev parent reply other threads:[~2007-05-05 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 20:59 [PATCH 2/3] tmscsim: remove bogus endianness conversions Guennadi Liakhovetski
2007-05-05 9:37 ` Christoph Hellwig [this message]
2007-05-05 21:18 ` Guennadi Liakhovetski
2007-05-06 11:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070505093751.GB9422@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@steeleye.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox