From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: James.Bottomley@SteelEye.com, linux-scsi@vger.kernel.org,
ricknu-0@student.ltu.se
Subject: Re: [patch 16/30] drivers/scsi/aic7xxx_old: Convert to generic boolean-values
Date: Tue, 08 May 2007 14:44:45 -0700 (PDT) [thread overview]
Message-ID: <20070508.144445.88474913.davem@davemloft.net> (raw)
In-Reply-To: <20070508131152.0003b770.akpm@linux-foundation.org>
From: Andrew Morton <akpm@linux-foundation.org>
Date: Tue, 8 May 2007 13:11:52 -0700
> On Tue, 08 May 2007 14:24:32 -0500
> James Bottomley <James.Bottomley@SteelEye.com> wrote:
>
> > However, could we compromise and just add TRUE = true, FALSE = false to
> > the enum?
>
> That sounds sane. But I don't recall all the details of the discussion
> and perhaps I'm missing something.
>
> I think the whole bool/true/false thing is pretty dissatisfactory really.
> Java gets this right and C cannot and will not and we end up with people
> using true and false as plain old "1" and "0".
I think it's more important to be consistent across the entire tree,
whatever we choose, than to be "nice" and add compat define hacks for
the sake of a select few stubborn drivers.
If you're going to add those ugly "#define TRUE true" bits, the whole
point of the change is lost so you might as not make it at all.
next prev parent reply other threads:[~2007-05-08 21:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-26 7:35 [patch 16/30] drivers/scsi/aic7xxx_old: Convert to generic boolean-values akpm
2007-05-07 19:50 ` James Bottomley
2007-05-07 21:06 ` Andrew Morton
2007-05-07 21:11 ` Andrew Morton
2007-05-08 4:13 ` Richard Knutsson
2007-05-08 15:11 ` James Bottomley
2007-05-08 19:14 ` Andrew Morton
2007-05-08 19:24 ` James Bottomley
2007-05-08 20:11 ` Andrew Morton
2007-05-08 20:41 ` James Bottomley
2007-05-08 21:44 ` David Miller [this message]
2007-05-08 21:59 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070508.144445.88474913.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ricknu-0@student.ltu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox