From: Christof Schmitt <christof.schmitt@de.ibm.com>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: Swen Schillig <swen.schillig@freenet.de>,
linux-scsi@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH] zfcp: Stop system after memory corruption
Date: Tue, 8 May 2007 14:58:24 +0200 [thread overview]
Message-ID: <20070508125824.GA14085@schmichrtp> (raw)
In-Reply-To: <646765f40705070856y28d958f8xe2e286ab347d63a5@mail.gmail.com>
On Tue, May 08, 2007 at 01:56:07AM +1000, Julian Calaby wrote:
> >From: Christof Schmitt <christof.schmitt@de.ibm.com>
> [snip]
> >- ZFCP_LOG_NORMAL("bug: unexpected inbound "
> >- "packet on adapter %s "
> >- "(reqid=0x%lx, "
> >- "first_element=%d, "
> >- "elements_processed=%d)\n",
[...]
> As a minor quibble, may I suggest that these lines belong just above
> the panic introduced above? I assume that they'd be useful for
> debugging should this situation occur.
If this problem occurs, the administrator of the Linux system will be
advised to dump the Linux system and to also capture the logs from the
FCP adapter. The memory dump already contains the information about the
unexpected packet and also information about the last requests
sent to the FCP adapter. So, the messages do not provide additional
debug data, and i removed them to simplify the code.
Christof Schmitt
next prev parent reply other threads:[~2007-05-08 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 14:35 [PATCH] zfcp: Stop system after memory corruption Swen Schillig
2007-05-07 15:56 ` Julian Calaby
2007-05-08 12:58 ` Christof Schmitt [this message]
2007-05-08 13:24 ` Julian Calaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070508125824.GA14085@schmichrtp \
--to=christof.schmitt@de.ibm.com \
--cc=julian.calaby@gmail.com \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=swen.schillig@freenet.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox