linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Satyam Sharma <satyam.sharma@gmail.com>
Cc: Simon Arlott <simon@fire.lp0.eu>,
	James Bottomley <james.bottomley@steeleye.com>,
	Dave Jones <davej@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-scsi@vger.kernel.org, kernel-packagers@vger.kernel.org,
	"Robert P. J. Day" <rpjday@mindspring.com>
Subject: Re: Asynchronous scsi scanning
Date: Thu, 17 May 2007 11:20:23 -0600	[thread overview]
Message-ID: <20070517172023.GL10562@parisc-linux.org> (raw)
In-Reply-To: <a781481a0705171013j7ddc48edxfb4bdba515a3f53c@mail.gmail.com>

On Thu, May 17, 2007 at 10:43:06PM +0530, Satyam Sharma wrote:
> >No, it does matter.  Your suggestion doesn't work, because
> >/sys/module/scsi_mod/parameters/ belongs to the module code.  To create
> >a new attribute there, you use the module_param() code -- and there's
> >no way to have code called when your parameter is changed.

(thanks, Roland for pointing out that I'm incorrect about code being
called)

> Ok, thanks for pointing out that /sys/module/scsi_mod/parameters/wait...
> is _wrong_. Could you suggest something that would be _right_?

No, I can't, which is why I find it hard to like the idea of "use
sysfs".  I have no particular love for using a module like this, but
my preferred way (a new verb for /proc/scsi/scsi) isn't liked by others.
So here we stand.

> You're almost right here. But IMHO this is simply a case of
> doing something in some kernel subsystem in a proper/better
> way than it is being done presently.
> 
> Anyway, like I said on another thread, discussions here tend to be
> most productive only over code, so I'll try and make a patch to do
> this some other way.

Come up with a sensible suggestion, and I'll listen to you.  Code isn't
the issue.  API is the issue.

  reply	other threads:[~2007-05-17 17:20 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.64.0705131106160.3197@localhost.localdomain>
2007-05-13 16:06 ` why does x86 "make defconfig" build a single, lonely module? Dave Jones
2007-05-13 16:10   ` James Bottomley
2007-05-13 16:18     ` James Bottomley
2007-05-13 16:30       ` Dave Jones
2007-05-14  9:35       ` Satyam Sharma
2007-05-14  9:45         ` Satyam Sharma
2007-05-14 12:00           ` Satyam Sharma
2007-05-14 12:23             ` Satyam Sharma
2007-05-14 14:31               ` James Bottomley
2007-05-15  0:41                 ` Satyam Sharma
2007-05-15 11:26                   ` Simon Arlott
2007-05-15 12:02                     ` Asynchronous scsi scanning Matthew Wilcox
2007-05-15 16:30                       ` Simon Arlott
2007-05-15 17:29                         ` Matthew Wilcox
2007-05-15 21:56                           ` [PATCH] SCSI: Let users disable SCSI_WAIT_SCAN to be built Stefan Richter
2007-05-16 14:43                             ` Stefan Richter
2007-05-17 14:00                               ` James Bottomley
2007-05-17 17:02                                 ` Satyam Sharma
2007-05-15 23:27                           ` Asynchronous scsi scanning Satyam Sharma
2007-05-15 23:28                             ` Arjan van de Ven
2007-05-15 23:49                               ` Satyam Sharma
2007-05-16  2:51                             ` Matthew Wilcox
2007-05-16  2:59                               ` Roland Dreier
2007-05-17 17:13                               ` Satyam Sharma
2007-05-17 17:20                                 ` Matthew Wilcox [this message]
2007-05-17 17:41                                   ` Satyam Sharma
2007-05-17 18:24                                     ` Christoph Hellwig
2007-05-17 18:47                                       ` Satyam Sharma
2007-05-17 18:51                                         ` Christoph Hellwig
2007-05-17 19:04                                           ` Satyam Sharma
2007-05-17 19:39                                             ` Matthew Wilcox
2007-05-17 19:43                                               ` Benjamin LaHaise
2007-05-17 21:30                                                 ` Matthew Wilcox
2007-05-17 21:42                                                   ` Dave Jones
2007-05-17 22:00                                                     ` Peter Jones
2007-05-18 14:00                                                       ` Stefan Richter
2007-05-18  5:28                                                   ` Satyam Sharma
2007-05-18 11:24                                                     ` Matthew Wilcox
2007-05-18 13:14                                                       ` Satyam Sharma
2007-05-18  3:41                                                 ` Satyam Sharma
2007-05-17 17:32                             ` sysfs makes scaling suck " Benjamin LaHaise
2007-05-17 17:45                               ` James Bottomley
2007-05-17 17:49                                 ` Benjamin LaHaise
2007-05-19 16:30                                   ` Greg KH
2007-05-17 22:24                       ` Peter Jones
2007-05-13 16:20     ` why does x86 "make defconfig" build a single, lonely module? Robert P. J. Day
2007-05-13 16:27       ` James Bottomley
2007-05-13 16:37         ` Robert P. J. Day
2007-05-13 17:42         ` Simon Arlott
2007-05-13 17:48           ` James Bottomley
2007-05-13 18:26             ` Simon Arlott
2007-05-13 18:45               ` Dave Jones
2007-05-13 18:45               ` James Bottomley
2007-05-14 17:29             ` Jan Engelhardt
2007-05-14 18:46               ` Alan Cox
2007-05-14 20:06                 ` Jan Engelhardt
2007-05-13 16:28     ` Dave Jones
2007-05-13 20:38     ` Simon Arlott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070517172023.GL10562@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=davej@redhat.com \
    --cc=james.bottomley@steeleye.com \
    --cc=kernel-packagers@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rpjday@mindspring.com \
    --cc=satyam.sharma@gmail.com \
    --cc=simon@fire.lp0.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).