From: Christoph Hellwig <hch@infradead.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-scsi@vger.kernel.org, James.Bottomley@SteelEye.com,
davem@davemloft.net
Subject: Re: [PATCH] jazz_esp converted to use esp_core
Date: Tue, 22 May 2007 00:00:41 +0100 [thread overview]
Message-ID: <20070521230041.GA12090@infradead.org> (raw)
In-Reply-To: <20070521210224.GA24573@alpha.franken.de>
On Mon, May 21, 2007 at 11:02:24PM +0200, Thomas Bogendoerfer wrote:
> Hi,
>
> after chasing and fixing two jazz platform bugs and one MIPS dma mapping
> bug, I finally succeeded in using the Dave's new esp_core (great work,
> thank you Dave). Below is the patch.
Very nice driver. The only thing that confused me a little are
the various helper functions split out of esp_jazz_probe that
make the code a bit odd to read. Are these intentional or a carry
over from the previous driver?
> --- a/drivers/scsi/Makefile
> +++ b/drivers/scsi/Makefile
> @@ -121,7 +121,7 @@ obj-$(CONFIG_BLK_DEV_3W_XXXX_RAID) += 3w-xxxx.o
> obj-$(CONFIG_SCSI_3W_9XXX) += 3w-9xxx.o
> obj-$(CONFIG_SCSI_PPA) += ppa.o
> obj-$(CONFIG_SCSI_IMM) += imm.o
> -obj-$(CONFIG_JAZZ_ESP) += NCR53C9x.o jazz_esp.o
> +obj-$(CONFIG_JAZZ_ESP) += jazz_esp.o
Note to Dave: it probably would be nice to just build esp_scsi.o
from the makefile like the old NCR53C9x drivers did instead of the
Kconfig hackery, what do you think?
next prev parent reply other threads:[~2007-05-21 23:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 21:02 [PATCH] jazz_esp converted to use esp_core Thomas Bogendoerfer
2007-05-21 23:00 ` Christoph Hellwig [this message]
2007-05-21 23:14 ` Jeff Garzik
2007-05-21 23:41 ` David Miller
2007-05-21 23:45 ` Jeff Garzik
2007-05-21 23:54 ` David Miller
2007-05-22 8:04 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070521230041.GA12090@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=davem@davemloft.net \
--cc=linux-scsi@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox