Re: [patch 14/25] SCSI: use irq_handler_t where appropriate

Randy Dunlap
2007-05-24T15:11:56Z

On Thu, 24 May 2007 09:04:06 -0500 James Bottomley wrote:

> On Thu, 2007-05-24 at 01:51 -0400, Jeff Garzik wrote:
> > James Bottomley wrote:
> > > It's not a bug fix or even an enhancement. Historically, it is quite
> > > difficult to get maintainers to ack these ... particularly if you don't
> > > cc them.
> >
> > If neither you nor the maintainers are reading and responding to patches
> > sent to linux-scsi, I don't think the problem is sitting in my chair.
>
> Oh come off it ... You've been around long enough to know that
> maintainers are not always watching everything ... it would be nice if
> they were, but to give a patch the best shot at review, you try to
> attract their attention. Specifically, in this case, you should cc the
> maintainers and you should have a subject line explaining that you are
> modifying their driver. It is very easy to ignore a patch that's simply
> waved at the SCSI list with a generic subject line.

I can understand subsystem maintainers ignoring lkml, but ignoring
the subsystem mailing list makes no sense to me, especially if the
subject contains "[PATCH]".

> > If others have SCSI patches that have been sitting in limbo for weeks or
> > months, send them to me, and I'll queue them in misc-2.6.git#scsi.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***