From: Andrew Morton <akpm@linux-foundation.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: linux-scsi@vger.kernel.org, bunk@stusta.de
Subject: Re: [patch 02/25] drivers/scsi/advansys.c: cleanups
Date: Wed, 23 May 2007 16:33:59 -0700 [thread overview]
Message-ID: <20070523163359.3c71f44e.akpm@linux-foundation.org> (raw)
In-Reply-To: <1179962491.5569.62.camel@mulgrave.il.steeleye.com>
On Wed, 23 May 2007 18:21:31 -0500
James Bottomley <James.Bottomley@SteelEye.com> wrote:
> On Wed, 2007-05-23 at 14:41 -0700, akpm@linux-foundation.org wrote:
> > From: Adrian Bunk <bunk@stusta.de>
> >
> > - remove the unneeded advansys.h
> > - remove the unused advansys_setup()
>
> This isn't quite right, though, is it? advansys_setup() should be used.
>
> It looks like there was a bogus conversion away from init/main.c which
> left the function dangling. Isn't the correct thing to do to wire it up
> in advansys_detect() which is where it should have been in the first
> place.
>
Even going back to linux-2.4.2 I can find no caller to advansys_setup().
Or was its call buried in the magical template macros?
next prev parent reply other threads:[~2007-05-23 23:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 21:41 [patch 02/25] drivers/scsi/advansys.c: cleanups akpm
2007-05-23 23:21 ` James Bottomley
2007-05-23 23:33 ` Andrew Morton [this message]
2007-05-24 1:22 ` James Bottomley
2007-05-24 9:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070523163359.3c71f44e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@SteelEye.com \
--cc=bunk@stusta.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox