Re: [patch 14/25] SCSI: use irq_handler_t where appropriate

Stefan Richter
2007-05-25T09:06:21Z

Randy Dunlap wrote:
> On Thu, 24 May 2007 09:04:06 -0500 James Bottomley wrote:
>> maintainers are not always watching everything ... it would be nice if
>> they were, but to give a patch the best shot at review, you try to
>> attract their attention. Specifically, in this case, you should cc the
>> maintainers and you should have a subject line explaining that you are
>> modifying their driver. It is very easy to ignore a patch that's simply
>> waved at the SCSI list with a generic subject line.
>
> I can understand subsystem maintainers ignoring lkml, but ignoring
> the subsystem mailing list makes no sense to me, especially if the
> subject contains "[PATCH]".

I mostly agree. It becomes difficult with cross-subsystem patches
though. The difficulty with such patches is that the subsystem
mailinglist which was chosen as adressee doesn't tell the whole picture,
and the subject, even if chosen carefully, often cannot explicitly tell
which places it touches.

On the other hand, submitters of nontrivial cross-subsystem patches can
be expected to put some extra care in their submission, i.e. to add
respective personal addresses. (And of course to include a diffstat!)

The patch "SCSI: use irq_handler_t where appropriate" is of course not a
patch of this kind. Also, it is of the sort which IMO doesn't need a
driver maintainer's ACK in the first place. Sure, it wouldn't have hurt
a lot to call it for example "SCSI: use irq_handler_t in aacraid and
qla2xxx", even though that information will be redundant /after/ it went
into a git tree.
--
Stefan Richter
-=====-=-=== -=-= ==--=