* [patch 1/1] scsi: cover up bugs^W^W^WFix up compiler warnings in megaraid driver
@ 2007-05-23 23:11 akpm
2007-05-25 20:28 ` Patro, Sumant
0 siblings, 1 reply; 4+ messages in thread
From: akpm @ 2007-05-23 23:11 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, akpm, mbligh
From: Martin Bligh <mbligh@google.com>
Fix up compiler warnings in megaraid driver
Signed-off-by: Martin J. Bligh <mbligh@google.com>
Cc: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/scsi/megaraid.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff -puN drivers/scsi/megaraid.c~scsi-cover-up-bugs-fix-up-compiler-warnings-in-megaraid-driver drivers/scsi/megaraid.c
--- a/drivers/scsi/megaraid.c~scsi-cover-up-bugs-fix-up-compiler-warnings-in-megaraid-driver
+++ a/drivers/scsi/megaraid.c
@@ -3571,7 +3571,7 @@ megadev_ioctl(struct inode *inode, struc
/*
* The user passthru structure
*/
- upthru = (mega_passthru __user *)MBOX(uioc)->xferaddr;
+ upthru = (mega_passthru __user *)(unsigned long)MBOX(uioc)->xferaddr;
/*
* Copy in the user passthru here.
@@ -3623,7 +3623,7 @@ megadev_ioctl(struct inode *inode, struc
/*
* Get the user data
*/
- if( copy_from_user(data, (char __user *)uxferaddr,
+ if( copy_from_user(data, (char __user *)(unsigned long) uxferaddr,
pthru->dataxferlen) ) {
rval = (-EFAULT);
goto freemem_and_return;
@@ -3649,7 +3649,7 @@ megadev_ioctl(struct inode *inode, struc
* Is data going up-stream
*/
if( pthru->dataxferlen && (uioc.flags & UIOC_RD) ) {
- if( copy_to_user((char __user *)uxferaddr, data,
+ if( copy_to_user((char __user *)(unsigned long) uxferaddr, data,
pthru->dataxferlen) ) {
rval = (-EFAULT);
}
@@ -3702,7 +3702,7 @@ freemem_and_return:
/*
* Get the user data
*/
- if( copy_from_user(data, (char __user *)uxferaddr,
+ if( copy_from_user(data, (char __user *)(unsigned long) uxferaddr,
uioc.xferlen) ) {
pci_free_consistent(pdev,
@@ -3742,7 +3742,7 @@ freemem_and_return:
* Is data going up-stream
*/
if( uioc.xferlen && (uioc.flags & UIOC_RD) ) {
- if( copy_to_user((char __user *)uxferaddr, data,
+ if( copy_to_user((char __user *)(unsigned long) uxferaddr, data,
uioc.xferlen) ) {
rval = (-EFAULT);
_
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [patch 1/1] scsi: cover up bugs^W^W^WFix up compiler warnings in megaraid driver
2007-05-23 23:11 [patch 1/1] scsi: cover up bugs^W^W^WFix up compiler warnings in megaraid driver akpm
@ 2007-05-25 20:28 ` Patro, Sumant
2007-05-25 21:45 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Patro, Sumant @ 2007-05-25 20:28 UTC (permalink / raw)
To: akpm, James.Bottomley; +Cc: linux-scsi, mbligh
Ack.
--Sumant
-----Original Message-----
From: linux-scsi-owner@vger.kernel.org
[mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of
akpm@linux-foundation.org
Sent: Wednesday, May 23, 2007 4:12 PM
To: James.Bottomley@steeleye.com
Cc: linux-scsi@vger.kernel.org; akpm@linux-foundation.org;
mbligh@google.com
Subject: [patch 1/1] scsi: cover up bugs^W^W^WFix up compiler warnings
in megaraid driver
From: Martin Bligh <mbligh@google.com>
Fix up compiler warnings in megaraid driver
Signed-off-by: Martin J. Bligh <mbligh@google.com>
Cc: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/scsi/megaraid.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff -puN
drivers/scsi/megaraid.c~scsi-cover-up-bugs-fix-up-compiler-warnings-in-m
egaraid-driver drivers/scsi/megaraid.c
---
a/drivers/scsi/megaraid.c~scsi-cover-up-bugs-fix-up-compiler-warnings-in
-megaraid-driver
+++ a/drivers/scsi/megaraid.c
@@ -3571,7 +3571,7 @@ megadev_ioctl(struct inode *inode, struc
/*
* The user passthru structure
*/
- upthru = (mega_passthru __user
*)MBOX(uioc)->xferaddr;
+ upthru = (mega_passthru __user *)(unsigned
long)MBOX(uioc)->xferaddr;
/*
* Copy in the user passthru here.
@@ -3623,7 +3623,7 @@ megadev_ioctl(struct inode *inode, struc
/*
* Get the user data
*/
- if( copy_from_user(data, (char __user
*)uxferaddr,
+ if( copy_from_user(data, (char __user
*)(unsigned long) uxferaddr,
pthru->dataxferlen) ) {
rval = (-EFAULT);
goto freemem_and_return;
@@ -3649,7 +3649,7 @@ megadev_ioctl(struct inode *inode, struc
* Is data going up-stream
*/
if( pthru->dataxferlen && (uioc.flags & UIOC_RD)
) {
- if( copy_to_user((char __user
*)uxferaddr, data,
+ if( copy_to_user((char __user
*)(unsigned long) uxferaddr, data,
pthru->dataxferlen) ) {
rval = (-EFAULT);
}
@@ -3702,7 +3702,7 @@ freemem_and_return:
/*
* Get the user data
*/
- if( copy_from_user(data, (char __user
*)uxferaddr,
+ if( copy_from_user(data, (char __user
*)(unsigned long) uxferaddr,
uioc.xferlen) )
{
pci_free_consistent(pdev,
@@ -3742,7 +3742,7 @@ freemem_and_return:
* Is data going up-stream
*/
if( uioc.xferlen && (uioc.flags & UIOC_RD) ) {
- if( copy_to_user((char __user
*)uxferaddr, data,
+ if( copy_to_user((char __user
*)(unsigned long) uxferaddr, data,
uioc.xferlen) )
{
rval = (-EFAULT);
_
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 1/1] scsi: cover up bugs^W^W^WFix up compiler warnings in megaraid driver
2007-05-25 20:28 ` Patro, Sumant
@ 2007-05-25 21:45 ` Andrew Morton
2007-05-30 1:10 ` Patro, Sumant
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2007-05-25 21:45 UTC (permalink / raw)
To: Patro, Sumant; +Cc: James.Bottomley, linux-scsi, mbligh
On Fri, 25 May 2007 14:28:19 -0600 "Patro, Sumant" <Sumant.Patro@lsi.com> wrote:
> Ack.
Thanks.
While we're here...
box:/usr/src/25> grep -i lsi MAINTAINERS
LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI)
M: Eric.Moore@lsi.com
M: support@lsi.com
L: mpt_linux_developer@lsi.com
W: http://www.lsilogic.com/support
LSILOGIC/SYMBIOS/NCR 53C8XX and 53C1010 PCI-SCSI drivers
W: http://megaraid.lsilogic.com
USB KAWASAKI LSI DRIVER
M: uclinux-v850@lsi.nec.co.jp
box:/usr/src/25> grep -i sumant MAINTAINERS
box:/usr/src/25>
Could I ask that you review the MAINTAINERS file and ensure that
all appropriate lsil developers are appropriately mentioned and that
all drivers which lsil look after have the appropriate entries?
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [patch 1/1] scsi: cover up bugs^W^W^WFix up compiler warnings in megaraid driver
2007-05-25 21:45 ` Andrew Morton
@ 2007-05-30 1:10 ` Patro, Sumant
0 siblings, 0 replies; 4+ messages in thread
From: Patro, Sumant @ 2007-05-30 1:10 UTC (permalink / raw)
To: Andrew Morton; +Cc: James.Bottomley, linux-scsi, mbligh
Hello Andrew,
The email-id megaraidlinux@lsi.com is the alias for driver
developers for MegaRAID product. This id includes my name. Recently I
submitted patch to update the MAINTAINERS to add this id.
Regards,
Sumant
-----Original Message-----
From: Andrew Morton [mailto:akpm@linux-foundation.org]
Sent: Friday, May 25, 2007 2:46 PM
To: Patro, Sumant
Cc: James.Bottomley@steeleye.com; linux-scsi@vger.kernel.org;
mbligh@google.com
Subject: Re: [patch 1/1] scsi: cover up bugs^W^W^WFix up compiler
warnings in megaraid driver
On Fri, 25 May 2007 14:28:19 -0600 "Patro, Sumant"
<Sumant.Patro@lsi.com> wrote:
> Ack.
Thanks.
While we're here...
box:/usr/src/25> grep -i lsi MAINTAINERS
LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI)
M: Eric.Moore@lsi.com
M: support@lsi.com
L: mpt_linux_developer@lsi.com
W: http://www.lsilogic.com/support
LSILOGIC/SYMBIOS/NCR 53C8XX and 53C1010 PCI-SCSI drivers
W: http://megaraid.lsilogic.com
USB KAWASAKI LSI DRIVER
M: uclinux-v850@lsi.nec.co.jp
box:/usr/src/25> grep -i sumant MAINTAINERS
box:/usr/src/25>
Could I ask that you review the MAINTAINERS file and ensure that
all appropriate lsil developers are appropriately mentioned and that
all drivers which lsil look after have the appropriate entries?
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-05-30 1:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-23 23:11 [patch 1/1] scsi: cover up bugs^W^W^WFix up compiler warnings in megaraid driver akpm
2007-05-25 20:28 ` Patro, Sumant
2007-05-25 21:45 ` Andrew Morton
2007-05-30 1:10 ` Patro, Sumant
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).