From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [patch 4/6] ps3: Disk Storage Driver Date: Tue, 19 Jun 2007 19:19:38 +0200 Message-ID: <20070619171938.GA21935@lst.de> References: <20070615113919.142332000@pademelon.sonytel.be> <20070615120848.352093000@pademelon.sonytel.be> <20070619054324.GA18542@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from verein.lst.de ([213.95.11.210]:51016 "EHLO mail.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757066AbXFSRUM (ORCPT ); Tue, 19 Jun 2007 13:20:12 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Geert Uytterhoeven Cc: Christoph Hellwig , Paul Mackerras , linuxppc-dev@ozlabs.org, Jens Axboe , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Jun 19, 2007 at 02:51:25PM +0200, Geert Uytterhoeven wrote: > On Tue, 19 Jun 2007, Christoph Hellwig wrote: > > On Fri, Jun 15, 2007 at 01:39:23PM +0200, Geert Uytterhoeven wrote: > > > From: Geert Uytterhoeven > > > > > > Add a Disk Storage Driver for the PS3: > > > - Implemented as a block device driver with a dynamic major > > > - Disk names (and partitions) are of the format ps3d%c(%u) > > > - Uses software scatter-gather with a 64 KiB bounce buffer as the hypervisor > > > doesn't support scatter-gather > > > > Looks good to me. Only nitpicks are: > > > > - ps3disk_priv should probably be an inline function instead of a macro > > I used a macro because you can do > > ps3disk_pri(dev) = ...; I'm not exactly a fan of macros used as lvalues, but if you really want this it can go in.