* [patch 3/3] scsi: wd33c93 needs <asm/irq.h> [not found] <20070720164043.523003359@mail.of.borg> @ 2007-07-20 16:40 ` Geert Uytterhoeven 2007-07-20 16:48 ` James Bottomley 2007-07-20 17:31 ` Ralf Baechle 0 siblings, 2 replies; 11+ messages in thread From: Geert Uytterhoeven @ 2007-07-20 16:40 UTC (permalink / raw) To: Andrew Morton Cc: linux-m68k, linux-kernel, James E.J. Bottomley, linux-scsi, linux-mips [-- Attachment #1: m68k-wd33c93-needs-asm-irq.diff --] [-- Type: text/plain, Size: 1014 bytes --] wd33c93 SCSI needs <asm/irq.h> on m68k drivers/scsi/wd33c93.c: In function 'wd33c93_host_reset': drivers/scsi/wd33c93.c:1582: error: implicit declaration of function 'disable_irq' drivers/scsi/wd33c93.c:1603: error: implicit declaration of function 'enable_irq' The driver still compiles on MIPS (CONFIG_SGIWD93_SCSI=y) Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/scsi/wd33c93.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/scsi/wd33c93.c +++ b/drivers/scsi/wd33c93.c @@ -89,6 +89,8 @@ #include <scsi/scsi_device.h> #include <scsi/scsi_host.h> +#include <asm/irq.h> + #include "wd33c93.h" #define optimum_sx_per(hostdata) (hostdata)->sx_table[1].period_ns -- Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h> 2007-07-20 16:40 ` [patch 3/3] scsi: wd33c93 needs <asm/irq.h> Geert Uytterhoeven @ 2007-07-20 16:48 ` James Bottomley 2007-07-20 17:05 ` Geert Uytterhoeven 2007-07-20 17:13 ` Adrian Bunk 2007-07-20 17:31 ` Ralf Baechle 1 sibling, 2 replies; 11+ messages in thread From: James Bottomley @ 2007-07-20 16:48 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Andrew Morton, linux-m68k, linux-kernel, linux-scsi, linux-mips On Fri, 2007-07-20 at 18:40 +0200, Geert Uytterhoeven wrote: > plain text document attachment (m68k-wd33c93-needs-asm-irq.diff) > wd33c93 SCSI needs <asm/irq.h> on m68k > > drivers/scsi/wd33c93.c: In function 'wd33c93_host_reset': > drivers/scsi/wd33c93.c:1582: error: implicit declaration of function 'disable_irq' > drivers/scsi/wd33c93.c:1603: error: implicit declaration of function 'enable_irq' > > The driver still compiles on MIPS (CONFIG_SGIWD93_SCSI=y) That's fixed here, isn't it: http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=078dda95c521b1c78d1b5da69ac90d581abc9951 (sorry about the lack of descriptive subject line) James ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h> 2007-07-20 16:48 ` James Bottomley @ 2007-07-20 17:05 ` Geert Uytterhoeven 2007-07-20 17:13 ` Adrian Bunk 1 sibling, 0 replies; 11+ messages in thread From: Geert Uytterhoeven @ 2007-07-20 17:05 UTC (permalink / raw) To: James Bottomley Cc: Andrew Morton, linux-m68k, linux-kernel, linux-scsi, linux-mips On Fri, 20 Jul 2007, James Bottomley wrote: > On Fri, 2007-07-20 at 18:40 +0200, Geert Uytterhoeven wrote: > > plain text document attachment (m68k-wd33c93-needs-asm-irq.diff) > > wd33c93 SCSI needs <asm/irq.h> on m68k > > > > drivers/scsi/wd33c93.c: In function 'wd33c93_host_reset': > > drivers/scsi/wd33c93.c:1582: error: implicit declaration of function 'disable_irq' > > drivers/scsi/wd33c93.c:1603: error: implicit declaration of function 'enable_irq' > > > > The driver still compiles on MIPS (CONFIG_SGIWD93_SCSI=y) > > That's fixed here, isn't it: > > http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=078dda95c521b1c78d1b5da69ac90d581abc9951 Indeed, thx! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h> 2007-07-20 16:48 ` James Bottomley 2007-07-20 17:05 ` Geert Uytterhoeven @ 2007-07-20 17:13 ` Adrian Bunk 1 sibling, 0 replies; 11+ messages in thread From: Adrian Bunk @ 2007-07-20 17:13 UTC (permalink / raw) To: James Bottomley Cc: Geert Uytterhoeven, Andrew Morton, linux-m68k, linux-kernel, linux-scsi, linux-mips On Fri, Jul 20, 2007 at 11:48:57AM -0500, James Bottomley wrote: > On Fri, 2007-07-20 at 18:40 +0200, Geert Uytterhoeven wrote: > > plain text document attachment (m68k-wd33c93-needs-asm-irq.diff) > > wd33c93 SCSI needs <asm/irq.h> on m68k > > > > drivers/scsi/wd33c93.c: In function 'wd33c93_host_reset': > > drivers/scsi/wd33c93.c:1582: error: implicit declaration of function 'disable_irq' > > drivers/scsi/wd33c93.c:1603: error: implicit declaration of function 'enable_irq' > > > > The driver still compiles on MIPS (CONFIG_SGIWD93_SCSI=y) > > That's fixed here, isn't it: > > http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=078dda95c521b1c78d1b5da69ac90d581abc9951 > > (sorry about the lack of descriptive subject line) It wasn't a compile error when I sent this patch to you for the first time 11 months ago... > James cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h> 2007-07-20 16:40 ` [patch 3/3] scsi: wd33c93 needs <asm/irq.h> Geert Uytterhoeven 2007-07-20 16:48 ` James Bottomley @ 2007-07-20 17:31 ` Ralf Baechle 2007-07-20 17:33 ` Christoph Hellwig 2007-07-20 17:34 ` Matthew Wilcox 1 sibling, 2 replies; 11+ messages in thread From: Ralf Baechle @ 2007-07-20 17:31 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Andrew Morton, linux-m68k, linux-kernel, James E.J. Bottomley, linux-scsi, linux-mips On Fri, Jul 20, 2007 at 06:40:46PM +0200, Geert Uytterhoeven wrote: > --- a/drivers/scsi/wd33c93.c > +++ b/drivers/scsi/wd33c93.c > @@ -89,6 +89,8 @@ > #include <scsi/scsi_device.h> > #include <scsi/scsi_host.h> > > +#include <asm/irq.h> These days that should probably be <linux/irq.h>. Ralf ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h> 2007-07-20 17:31 ` Ralf Baechle @ 2007-07-20 17:33 ` Christoph Hellwig 2007-07-20 17:43 ` Sergei Shtylyov 2007-07-20 17:46 ` Ralf Baechle 2007-07-20 17:34 ` Matthew Wilcox 1 sibling, 2 replies; 11+ messages in thread From: Christoph Hellwig @ 2007-07-20 17:33 UTC (permalink / raw) To: Ralf Baechle Cc: Geert Uytterhoeven, Andrew Morton, linux-m68k, linux-kernel, James E.J. Bottomley, linux-scsi, linux-mips On Fri, Jul 20, 2007 at 06:31:32PM +0100, Ralf Baechle wrote: > > +#include <asm/irq.h> > > These days that should probably be <linux/irq.h>. Not at all, linux/irq.h is something entirely different. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h> 2007-07-20 17:33 ` Christoph Hellwig @ 2007-07-20 17:43 ` Sergei Shtylyov 2007-07-20 17:50 ` Matthew Wilcox 2007-07-20 17:46 ` Ralf Baechle 1 sibling, 1 reply; 11+ messages in thread From: Sergei Shtylyov @ 2007-07-20 17:43 UTC (permalink / raw) To: Christoph Hellwig Cc: Ralf Baechle, Geert Uytterhoeven, Andrew Morton, linux-m68k, linux-kernel, James E.J. Bottomley, linux-scsi, linux-mips Hello Christoph: >>>+#include <asm/irq.h> >>These days that should probably be <linux/irq.h>. > Not at all, linux/irq.h is something entirely different. Actually, <linux/interrupt.h> WBR, Sergei ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h> 2007-07-20 17:43 ` Sergei Shtylyov @ 2007-07-20 17:50 ` Matthew Wilcox 2007-07-22 23:34 ` Al Viro 0 siblings, 1 reply; 11+ messages in thread From: Matthew Wilcox @ 2007-07-20 17:50 UTC (permalink / raw) To: Sergei Shtylyov Cc: Christoph Hellwig, Ralf Baechle, Geert Uytterhoeven, Andrew Morton, linux-m68k, linux-kernel, James E.J. Bottomley, linux-scsi, linux-mips On Fri, Jul 20, 2007 at 09:43:47PM +0400, Sergei Shtylyov wrote: > Hello Christoph: > > >>>+#include <asm/irq.h> > > >>These days that should probably be <linux/irq.h>. > > >Not at all, linux/irq.h is something entirely different. > > Actually, <linux/interrupt.h> Not for enable/disable_irq. For request_irq, yes. This is something that should be fixed. -- "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h> 2007-07-20 17:50 ` Matthew Wilcox @ 2007-07-22 23:34 ` Al Viro 0 siblings, 0 replies; 11+ messages in thread From: Al Viro @ 2007-07-22 23:34 UTC (permalink / raw) To: Matthew Wilcox Cc: Sergei Shtylyov, Christoph Hellwig, Ralf Baechle, Geert Uytterhoeven, Andrew Morton, linux-m68k, linux-kernel, James E.J. Bottomley, linux-scsi, linux-mips On Fri, Jul 20, 2007 at 11:50:50AM -0600, Matthew Wilcox wrote: > On Fri, Jul 20, 2007 at 09:43:47PM +0400, Sergei Shtylyov wrote: > > Hello Christoph: > > > > >>>+#include <asm/irq.h> > > > > >>These days that should probably be <linux/irq.h>. > > > > >Not at all, linux/irq.h is something entirely different. > > > > Actually, <linux/interrupt.h> > > Not for enable/disable_irq. For request_irq, yes. > > This is something that should be fixed. Now it is... FWIW, I suspect that absolute majority of asm/irq.h uses can be removed now. Next steps in irq.h/interrupt.h cleanups: * scouring asm/irq.h like it had been done for sparc32; the parts that are only used by relevant arch/ code should be taken there and includes _in_ asm/irq.h trimmed to minimum * separating tasklet.h, with interrupt.h still including it. Using it where needed. * asm/softirq.h (with stuff mostly taken there from asm/hardirq.h) and linux/softirq.h; again interrupt.h still should include it. * mechanical adding include of linux/interrupt.h to files that use request_irq/free_irq/enable_irq/disable_irq/irqreturn_t/IRQF_... ---> in the next merge window: * replace include of linux/interrupt.h in netdevice.h with that of linux/softirq.h. * trim uses of linux/interrupt.h that are not needed anymore. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h> 2007-07-20 17:33 ` Christoph Hellwig 2007-07-20 17:43 ` Sergei Shtylyov @ 2007-07-20 17:46 ` Ralf Baechle 1 sibling, 0 replies; 11+ messages in thread From: Ralf Baechle @ 2007-07-20 17:46 UTC (permalink / raw) To: Christoph Hellwig, Geert Uytterhoeven, Andrew Morton, linux-m68k, linux-kernel, James E.J. Bottomley, linux-scsi, linux-mips On Fri, Jul 20, 2007 at 06:33:59PM +0100, Christoph Hellwig wrote: > On Fri, Jul 20, 2007 at 06:31:32PM +0100, Ralf Baechle wrote: > > > +#include <asm/irq.h> > > > > These days that should probably be <linux/irq.h>. > > Not at all, linux/irq.h is something entirely different. Well, fine. But checkpatch.pl will bitch about this and other files. So one way or the other it's not quite kosher. Ralf ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h> 2007-07-20 17:31 ` Ralf Baechle 2007-07-20 17:33 ` Christoph Hellwig @ 2007-07-20 17:34 ` Matthew Wilcox 1 sibling, 0 replies; 11+ messages in thread From: Matthew Wilcox @ 2007-07-20 17:34 UTC (permalink / raw) To: Ralf Baechle Cc: Geert Uytterhoeven, Andrew Morton, linux-m68k, linux-kernel, James E.J. Bottomley, linux-scsi, linux-mips, Russell King On Fri, Jul 20, 2007 at 06:31:32PM +0100, Ralf Baechle wrote: > On Fri, Jul 20, 2007 at 06:40:46PM +0200, Geert Uytterhoeven wrote: > > +#include <asm/irq.h> > > These days that should probably be <linux/irq.h>. Go and read the comments at the top of linux/irq.h. And then report to Russell for your whipping. -- "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2007-07-22 23:34 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20070720164043.523003359@mail.of.borg>
2007-07-20 16:40 ` [patch 3/3] scsi: wd33c93 needs <asm/irq.h> Geert Uytterhoeven
2007-07-20 16:48 ` James Bottomley
2007-07-20 17:05 ` Geert Uytterhoeven
2007-07-20 17:13 ` Adrian Bunk
2007-07-20 17:31 ` Ralf Baechle
2007-07-20 17:33 ` Christoph Hellwig
2007-07-20 17:43 ` Sergei Shtylyov
2007-07-20 17:50 ` Matthew Wilcox
2007-07-22 23:34 ` Al Viro
2007-07-20 17:46 ` Ralf Baechle
2007-07-20 17:34 ` Matthew Wilcox
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).