* [PATCH] unexport sg v3 helper functions
@ 2007-07-22 1:06 FUJITA Tomonori
2007-07-23 12:02 ` Jens Axboe
0 siblings, 1 reply; 6+ messages in thread
From: FUJITA Tomonori @ 2007-07-22 1:06 UTC (permalink / raw)
To: jens.axboe; +Cc: linux-scsi, fujita.tomonori
blk_fill_sghdr_rq, blk_unmap_sghdr_rq, and blk_complete_sghdr_rq were
exported for bsg, however bsg was changed to support only sg v4.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
---
block/scsi_ioctl.c | 13 +++++--------
include/linux/blkdev.h | 5 -----
2 files changed, 5 insertions(+), 13 deletions(-)
diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
index 71bdf88..d359a71 100644
--- a/block/scsi_ioctl.c
+++ b/block/scsi_ioctl.c
@@ -214,8 +214,8 @@ int blk_verify_command(unsigned char *cm
}
EXPORT_SYMBOL_GPL(blk_verify_command);
-int blk_fill_sghdr_rq(request_queue_t *q, struct request *rq,
- struct sg_io_hdr *hdr, int has_write_perm)
+static int blk_fill_sghdr_rq(request_queue_t *q, struct request *rq,
+ struct sg_io_hdr *hdr, int has_write_perm)
{
memset(rq->cmd, 0, BLK_MAX_CDB); /* ATAPI hates garbage after CDB */
@@ -238,22 +238,20 @@ int blk_fill_sghdr_rq(request_queue_t *q
return 0;
}
-EXPORT_SYMBOL_GPL(blk_fill_sghdr_rq);
/*
* unmap a request that was previously mapped to this sg_io_hdr. handles
* both sg and non-sg sg_io_hdr.
*/
-int blk_unmap_sghdr_rq(struct request *rq, struct sg_io_hdr *hdr)
+static int blk_unmap_sghdr_rq(struct request *rq, struct sg_io_hdr *hdr)
{
blk_rq_unmap_user(rq->bio);
blk_put_request(rq);
return 0;
}
-EXPORT_SYMBOL_GPL(blk_unmap_sghdr_rq);
-int blk_complete_sghdr_rq(struct request *rq, struct sg_io_hdr *hdr,
- struct bio *bio)
+static int blk_complete_sghdr_rq(struct request *rq, struct sg_io_hdr *hdr,
+ struct bio *bio)
{
int r, ret = 0;
@@ -287,7 +285,6 @@ int blk_complete_sghdr_rq(struct request
return r;
}
-EXPORT_SYMBOL_GPL(blk_complete_sghdr_rq);
static int sg_io(struct file *file, request_queue_t *q,
struct gendisk *bd_disk, struct sg_io_hdr *hdr)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index f78965f..695e349 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -698,11 +698,6 @@ extern int blk_execute_rq(request_queue_
struct request *, int);
extern void blk_execute_rq_nowait(request_queue_t *, struct gendisk *,
struct request *, int, rq_end_io_fn *);
-extern int blk_fill_sghdr_rq(request_queue_t *, struct request *,
- struct sg_io_hdr *, int);
-extern int blk_unmap_sghdr_rq(struct request *, struct sg_io_hdr *);
-extern int blk_complete_sghdr_rq(struct request *, struct sg_io_hdr *,
- struct bio *);
extern int blk_verify_command(unsigned char *, int);
static inline request_queue_t *bdev_get_queue(struct block_device *bdev)
--
1.4.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] unexport sg v3 helper functions
2007-07-22 1:06 [PATCH] unexport sg v3 helper functions FUJITA Tomonori
@ 2007-07-23 12:02 ` Jens Axboe
2007-07-24 3:37 ` Douglas Gilbert
0 siblings, 1 reply; 6+ messages in thread
From: Jens Axboe @ 2007-07-23 12:02 UTC (permalink / raw)
To: FUJITA Tomonori; +Cc: linux-scsi, fujita.tomonori
On Sun, Jul 22 2007, FUJITA Tomonori wrote:
> blk_fill_sghdr_rq, blk_unmap_sghdr_rq, and blk_complete_sghdr_rq were
> exported for bsg, however bsg was changed to support only sg v4.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Acked-by: Jens Axboe <jens.axboe@oracle.com>
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] unexport sg v3 helper functions
2007-07-23 12:02 ` Jens Axboe
@ 2007-07-24 3:37 ` Douglas Gilbert
2007-07-24 6:49 ` Jens Axboe
0 siblings, 1 reply; 6+ messages in thread
From: Douglas Gilbert @ 2007-07-24 3:37 UTC (permalink / raw)
To: Jens Axboe; +Cc: FUJITA Tomonori, linux-scsi, fujita.tomonori
Jens Axboe wrote:
> On Sun, Jul 22 2007, FUJITA Tomonori wrote:
>> blk_fill_sghdr_rq, blk_unmap_sghdr_rq, and blk_complete_sghdr_rq were
>> exported for bsg, however bsg was changed to support only sg v4.
>>
>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>
> Acked-by: Jens Axboe <jens.axboe@oracle.com>
Why?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] unexport sg v3 helper functions
2007-07-24 3:37 ` Douglas Gilbert
@ 2007-07-24 6:49 ` Jens Axboe
2007-07-24 11:23 ` Douglas Gilbert
0 siblings, 1 reply; 6+ messages in thread
From: Jens Axboe @ 2007-07-24 6:49 UTC (permalink / raw)
To: Douglas Gilbert; +Cc: FUJITA Tomonori, linux-scsi, fujita.tomonori
On Mon, Jul 23 2007, Douglas Gilbert wrote:
> Jens Axboe wrote:
> > On Sun, Jul 22 2007, FUJITA Tomonori wrote:
> >> blk_fill_sghdr_rq, blk_unmap_sghdr_rq, and blk_complete_sghdr_rq were
> >> exported for bsg, however bsg was changed to support only sg v4.
> >>
> >> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> >
> > Acked-by: Jens Axboe <jens.axboe@oracle.com>
>
> Why?
The reasoning is right there, a few lines up - bsg doesn't support sg v3
commands.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] unexport sg v3 helper functions
2007-07-24 6:49 ` Jens Axboe
@ 2007-07-24 11:23 ` Douglas Gilbert
2007-07-24 11:34 ` Jens Axboe
0 siblings, 1 reply; 6+ messages in thread
From: Douglas Gilbert @ 2007-07-24 11:23 UTC (permalink / raw)
To: Jens Axboe; +Cc: FUJITA Tomonori, linux-scsi, fujita.tomonori
Jens Axboe wrote:
> On Mon, Jul 23 2007, Douglas Gilbert wrote:
>> Jens Axboe wrote:
>>> On Sun, Jul 22 2007, FUJITA Tomonori wrote:
>>>> blk_fill_sghdr_rq, blk_unmap_sghdr_rq, and blk_complete_sghdr_rq were
>>>> exported for bsg, however bsg was changed to support only sg v4.
>>>>
>>>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>>> Acked-by: Jens Axboe <jens.axboe@oracle.com>
>> Why?
>
> The reasoning is right there, a few lines up - bsg doesn't support sg v3
> commands.
I can read.
Why doesn't bsg support sg v3 commands?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] unexport sg v3 helper functions
2007-07-24 11:23 ` Douglas Gilbert
@ 2007-07-24 11:34 ` Jens Axboe
0 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2007-07-24 11:34 UTC (permalink / raw)
To: Douglas Gilbert; +Cc: FUJITA Tomonori, linux-scsi, fujita.tomonori
On Tue, Jul 24 2007, Douglas Gilbert wrote:
> Jens Axboe wrote:
> > On Mon, Jul 23 2007, Douglas Gilbert wrote:
> >> Jens Axboe wrote:
> >>> On Sun, Jul 22 2007, FUJITA Tomonori wrote:
> >>>> blk_fill_sghdr_rq, blk_unmap_sghdr_rq, and blk_complete_sghdr_rq were
> >>>> exported for bsg, however bsg was changed to support only sg v4.
> >>>>
> >>>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> >>> Acked-by: Jens Axboe <jens.axboe@oracle.com>
> >> Why?
> >
> > The reasoning is right there, a few lines up - bsg doesn't support sg v3
> > commands.
>
> I can read.
Then write better questions "Why?" isn't very useful.
> Why doesn't bsg support sg v3 commands?
You should know, the discussion on that happened at the storage summit
and on linux-scsi. It was decided to drop sg v3 support from bsg, and
only focus on making bsg the driver for sg v4 commands.
As you know, we already have dual paths for sg v3. For sg v4 we can get
rid of that pain, and just have a single driver for handling that.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-07-24 11:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-22 1:06 [PATCH] unexport sg v3 helper functions FUJITA Tomonori
2007-07-23 12:02 ` Jens Axboe
2007-07-24 3:37 ` Douglas Gilbert
2007-07-24 6:49 ` Jens Axboe
2007-07-24 11:23 ` Douglas Gilbert
2007-07-24 11:34 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).