From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH] unexport sg v3 helper functions Date: Tue, 24 Jul 2007 13:34:33 +0200 Message-ID: <20070724113433.GR3287@kernel.dk> References: <20070722033008L.tomof@acm.org> <20070723120222.GI11657@kernel.dk> <46A57410.1090605@torque.net> <20070724064954.GD3287@kernel.dk> <46A5E12E.2060804@torque.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from brick.kernel.dk ([80.160.20.94]:26375 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765572AbXGXLeL (ORCPT ); Tue, 24 Jul 2007 07:34:11 -0400 Content-Disposition: inline In-Reply-To: <46A5E12E.2060804@torque.net> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Douglas Gilbert Cc: FUJITA Tomonori , linux-scsi@vger.kernel.org, fujita.tomonori@lab.ntt.co.jp On Tue, Jul 24 2007, Douglas Gilbert wrote: > Jens Axboe wrote: > > On Mon, Jul 23 2007, Douglas Gilbert wrote: > >> Jens Axboe wrote: > >>> On Sun, Jul 22 2007, FUJITA Tomonori wrote: > >>>> blk_fill_sghdr_rq, blk_unmap_sghdr_rq, and blk_complete_sghdr_rq were > >>>> exported for bsg, however bsg was changed to support only sg v4. > >>>> > >>>> Signed-off-by: FUJITA Tomonori > >>> Acked-by: Jens Axboe > >> Why? > > > > The reasoning is right there, a few lines up - bsg doesn't support sg v3 > > commands. > > I can read. Then write better questions "Why?" isn't very useful. > Why doesn't bsg support sg v3 commands? You should know, the discussion on that happened at the storage summit and on linux-scsi. It was decided to drop sg v3 support from bsg, and only focus on making bsg the driver for sg v4 commands. As you know, we already have dual paths for sg v3. For sg v4 we can get rid of that pain, and just have a single driver for handling that. -- Jens Axboe