2.6.23-rc1-mm1: SCSI_SRP_ATTRS compile error

2.6.23-rc1-mm1: SCSI_SRP_ATTRS compile error

[Adrian Bunk]

On Wed, Jul 25, 2007 at 05:36:56PM +0100, Andy Whitcroft wrote:
> Of the machines we test releases on automatically this only compiles on
> NUMA-Q and does not boot there (some PCI issue).
> 
> 
> ppc64 (beavis):
> 
> drivers/built-in.o(.text+0xd2784): In function `.srp_rport_add':
> : undefined reference to `.scsi_tgt_it_nexus_create'
> drivers/built-in.o(.text+0xd2884): In function `.srp_rport_del':
> : undefined reference to `.scsi_tgt_it_nexus_destroy'
> make: *** [.tmp_vmlinux1] Error 1
> 
> 
> x86_64 (bl6-13):
> 
> ERROR: "scsi_tgt_it_nexus_destroy" [drivers/scsi/scsi_transport_srp.ko]
> undefined!
> ERROR: "scsi_tgt_it_nexus_create" [drivers/scsi/scsi_transport_srp.ko]
> undefined!
> make[1]: *** [__modpost] Error 1
>...

Caused-By  : git-scsi-target.patch
Workaround : enable CONFIG_SCSI_TGT

Is there any good reason why all the SCSI transport attributes options 
are user visible?

With an answer to this question I can fix this bug.

> -apw

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: 2.6.23-rc1-mm1: SCSI_SRP_ATTRS compile error

[FUJITA Tomonori]

From: Adrian Bunk <bunk@stusta.de>
Subject: 2.6.23-rc1-mm1: SCSI_SRP_ATTRS compile error
Date: Wed, 25 Jul 2007 20:06:18 +0200

> On Wed, Jul 25, 2007 at 05:36:56PM +0100, Andy Whitcroft wrote:
> > Of the machines we test releases on automatically this only compiles on
> > NUMA-Q and does not boot there (some PCI issue).
> > 
> > 
> > ppc64 (beavis):
> > 
> > drivers/built-in.o(.text+0xd2784): In function `.srp_rport_add':
> > : undefined reference to `.scsi_tgt_it_nexus_create'
> > drivers/built-in.o(.text+0xd2884): In function `.srp_rport_del':
> > : undefined reference to `.scsi_tgt_it_nexus_destroy'
> > make: *** [.tmp_vmlinux1] Error 1
> > 
> > 
> > x86_64 (bl6-13):
> > 
> > ERROR: "scsi_tgt_it_nexus_destroy" [drivers/scsi/scsi_transport_srp.ko]
> > undefined!
> > ERROR: "scsi_tgt_it_nexus_create" [drivers/scsi/scsi_transport_srp.ko]
> > undefined!
> > make[1]: *** [__modpost] Error 1
> >...
> 
> Caused-By  : git-scsi-target.patch
> Workaround : enable CONFIG_SCSI_TGT

Sorry about this.

Andrew, could you drop the scsi-target tree from -mm?

I was surprised that the scsi-target tree is still in -mm (it had been
tested in -mm before the mainline inclusion). I guess that it's the
right way to push scsi-target stuff into -mm via James' scsi-misc.


> Is there any good reason why all the SCSI transport attributes options 
> are user visible?

No, I messed up the dependency somewhere. I'll fix it before it is
merged into scsi-misc.

Thanks,

[-mm patch] make scsi_host_link_pm_policy() static

[Adrian Bunk]

On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc6-mm1:
>...
> +ata-ahci-alpm-expose-power-management-policy-option-to-users.patch
>...
>  ata things
>...

scsi_host_link_pm_policy() can become static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---
--- linux-2.6.23-rc1-mm1/drivers/scsi/scsi_sysfs.c.old	2007-07-26 21:31:24.000000000 +0200
+++ linux-2.6.23-rc1-mm1/drivers/scsi/scsi_sysfs.c	2007-07-26 21:31:57.000000000 +0200
@@ -200,7 +200,7 @@
 	{ SHOST_MEDIUM_POWER, "medium_power" },
 };
 
-const char *scsi_host_link_pm_policy(enum scsi_host_link_pm policy)
+static const char *scsi_host_link_pm_policy(enum scsi_host_link_pm policy)
 {
 	int i;
 	char *name = NULL;