From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: aacraid@adaptec.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] dpt_i2o: convert to SCSI hotplug model
Date: Mon, 30 Jul 2007 22:29:35 +0100 [thread overview]
Message-ID: <20070730212935.GC4987@infradead.org> (raw)
In-Reply-To: <20070730211917.GK21219@parisc-linux.org>
On Mon, Jul 30, 2007 at 03:19:18PM -0600, Matthew Wilcox wrote:
> dpt_i2o: Convert to new SCSI driver model
>
> - Delete refereces to HOSTS_C
> - Switch to module_init/module_exit instead of detect/release
> - Don't pass around the host template and rename it to adpt_template
> - Switch from scsi_register/scsi_unregister to scsi_host_alloc,
> scsi_add_host, scsi_scan_host and scsi_host_put.
Looks fine to me except that I'd prefer to see adpt_detect merged into
adpt_init even if that means moving some code around and the cleanup
in the init path might better be just opencoded than re-using adpt_exit
especiall if that one's going to get a little more complicated later on.
next prev parent reply other threads:[~2007-07-30 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 21:19 [PATCH] dpt_i2o: convert to SCSI hotplug model Matthew Wilcox
2007-07-30 21:29 ` Christoph Hellwig [this message]
2007-07-30 21:47 ` Jeff Garzik
2007-07-31 12:47 ` Salyzyn, Mark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070730212935.GC4987@infradead.org \
--to=hch@infradead.org \
--cc=aacraid@adaptec.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox