From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Correct some mistakes in drivers using the scsi hotplug model
Date: Tue, 31 Jul 2007 15:57:23 +0100 [thread overview]
Message-ID: <20070731145723.GA18819@infradead.org> (raw)
In-Reply-To: <20070731145227.GP21219@parisc-linux.org>
On Tue, Jul 31, 2007 at 08:52:28AM -0600, Matthew Wilcox wrote:
> On Tue, Jul 31, 2007 at 09:42:25AM -0500, James Bottomley wrote:
> > Rather than changing this in every 53c700 based driver, shouldn't it
> > just be added to NCR_700_release()?
>
> Then I'd have to change the few drivers that weren't leaking scsi_hosts
> ;-) But I can, if that's what you prefer.
I don't think it's a good idea. scsi_hhost_put should be the very
last thing in the release method and all the drivers do some kind
of cleanup after detaching from the generic ncr53c00 driver.
next prev parent reply other threads:[~2007-07-31 14:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 12:55 [PATCH] Correct some mistakes in drivers using the scsi hotplug model Matthew Wilcox
2007-07-31 13:27 ` Jeff Garzik
2007-07-31 14:42 ` James Bottomley
2007-07-31 14:52 ` Matthew Wilcox
2007-07-31 14:57 ` Christoph Hellwig [this message]
2007-07-31 15:05 ` James Bottomley
2007-07-31 16:00 ` Matthew Wilcox
2007-07-31 16:17 ` James Bottomley
2007-07-31 15:18 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070731145723.GA18819@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox