Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining

[Jens Axboe <jens.axboe@oracle.com>]

On Mon, Aug 06 2007, FUJITA Tomonori wrote:
> On Tue, 31 Jul 2007 23:12:26 +0300
> Boaz Harrosh <bharrosh@panasas.com> wrote:
> 
> > The tested Kernels:
> > 
> > 1. Jens's sglist-arch
> >   I was not able to pass all tests with this Kernel. For some reason when
> >   bigger than 256 pages commands are queued the Machine will run out
> >   of memory and will kill the test. After the test is killed the system
> >   is left with 10M of memory and can hardly reboot.
> >   I have done some prints at the queuecommand entry in scsi_debug.c
> >   and I can see that I receive the expected large sg_count and bufflen
> >   but unlike other tests I get a different pointer at scsi_sglist().
> >   In other tests since nothing is happening at this machine while in
> >   the test, the sglist pointer is always the same. commands comes in,
> >   allocates memory, do nothing in scsi_debug, freed, and returns. 
> >   I suspect sglist leak or allocation bug.
> 
> Ok, I found the leak.
> 
> 
> From 011c05c2e514d1db4834147ed83526473711b0a3 Mon Sep 17 00:00:00 2001
> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Date: Mon, 6 Aug 2007 16:16:24 +0900
> Subject: [PATCH] fix sg chaining leak
> 
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> ---
>  drivers/scsi/scsi_lib.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 5884b1b..25988b9 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -48,7 +48,6 @@ static struct scsi_host_sg_pool scsi_sg_pools[] = {
>  	SP(32),
>  	SP(64),
>  	SP(128),
> -	SP(256),
>  };
>  #undef SP

Thanks Tomo! Trying to catch up with mails, will apply this one right
away.

-- 
Jens Axboe