From: Matthew Wilcox <matthew@wil.cx>
To: Christof Schmitt <christof.schmitt@de.ibm.com>
Cc: linux-scsi@vger.kernel.org, James Smart <James.Smart@Emulex.Com>
Subject: Re: [PATCH] FC transport: Allow LLDD to disable LUN scanning
Date: Tue, 21 Aug 2007 09:46:34 -0600 [thread overview]
Message-ID: <20070821154634.GA9163@parisc-linux.org> (raw)
In-Reply-To: <20070821153716.GB11101@schmichrtp.de.ibm.com>
On Tue, Aug 21, 2007 at 05:37:17PM +0200, Christof Schmitt wrote:
> unsigned long show_host_system_hostname:1;
> +
> + /* The driver can disable the LUN scanning from the FC transport class */
> + unsigned long disable_target_scan:1;
> };
The comment exceeds 80 columns. Why have a comment at all, none of the
other fields here do, and it doesn't seem to add anything to me.
--
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-08-21 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-21 15:37 [PATCH] FC transport: Allow LLDD to disable LUN scanning Christof Schmitt
2007-08-21 15:46 ` Matthew Wilcox [this message]
2007-08-22 8:28 ` Christof Schmitt
2007-08-22 8:34 ` Update: " Christof Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070821154634.GA9163@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Smart@Emulex.Com \
--cc=christof.schmitt@de.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox