public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Gilbert Wu <Gilbert_Wu@adaptec.com>
Cc: Linux-scsi@vger.kernel.org
Subject: Re: [PATCH] aic94xx: fix smartctl utility problem
Date: Thu, 6 Sep 2007 06:06:02 -0400	[thread overview]
Message-ID: <20070906100602.GA22773@havoc.gtf.org> (raw)
In-Reply-To: <1189031155.6108.8.camel@linux.site>

On Wed, Sep 05, 2007 at 03:25:55PM -0700, Gilbert Wu wrote:
>    Fixed the problem that "smartctl -a /dev/some_sata_disk -d ata"  does not work on SATA device.
>    ( The smartctl v5.38 does need "-d ata" option.)
>    The root cause is the aic94xx driver does not return ATA output register due to performance reason.
>    The aic94xx need check ATA command which need ATA output register and turn on internal flag to
>    enable firmware to return ATA output register to top layer.
>    It also add new ATA commands to ata.h sush as ATA_CMD_CHK_MEDIA_TYPE and ATA_CMD_SMART.
> 
> Signed-off-by: Gilbert Wu <gilbert_wu@adaptec.com>

All commands except for hot path READ/WRITE should be returning ATA
output registers.

Additionally, READ/WRITE should be returning ATA output registers,
if the READ/WRITE command did not succeed.

Any code that requires an "accepted list of commands" is problematic,
because it does not take into account vendor-specific commands.

	Jeff




  reply	other threads:[~2007-09-06 10:06 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-05 22:25 [PATCH] aic94xx: fix smartctl utility problem Gilbert Wu
2007-09-06 10:06 ` Jeff Garzik [this message]
2007-09-06 18:33   ` Wu, Gilbert
2007-09-07 23:00     ` Jeff Garzik
2007-09-07 23:58       ` Wu, Gilbert
  -- strict thread matches above, loose matches on Subject: below --
2007-09-14 12:30 Gilbert Wu
2007-09-14 17:26 ` Jeff Garzik
2007-09-14 17:30   ` Wu, Gilbert
2007-09-14 17:58 Gilbert Wu
2007-09-14 18:14 ` Jeff Garzik
2007-09-15 17:05 ` James Bottomley
2007-09-16 16:37   ` James Bottomley
2007-09-16 19:43     ` Jeff Garzik
2007-09-16 23:01     ` Douglas Gilbert
2007-09-16 23:21       ` James Bottomley
2007-09-17 20:53         ` Wu, Gilbert
2007-09-17 22:59           ` James Bottomley
2007-09-18  1:43             ` Wu, Gilbert
2007-09-18  3:31               ` James Bottomley
2007-09-21 18:53             ` Wu, Gilbert
2007-09-21 20:40               ` James Bottomley
2007-09-21 23:05                 ` Wu, Gilbert
2007-09-20 18:52         ` Douglas Gilbert
2007-09-18 20:35 ` Luben Tuikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070906100602.GA22773@havoc.gtf.org \
    --to=jeff@garzik.org \
    --cc=Gilbert_Wu@adaptec.com \
    --cc=Linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox