From: Jens Axboe <jens.axboe@oracle.com>
To: FUJITA Tomonori <tomof@acm.org>
Cc: linux-scsi@vger.kernel.org, James.Bottomley@SteelEye.com,
fujita.tomonori@lab.ntt.co.jp
Subject: Re: [PATCH] remove sglist_len
Date: Thu, 6 Sep 2007 14:25:03 +0200 [thread overview]
Message-ID: <20070906122502.GA5341@kernel.dk> (raw)
In-Reply-To: <20070906091901G.tomof@acm.org>
On Thu, Sep 06 2007, FUJITA Tomonori wrote:
> This is against Jens' sg chaining branch.
>
> http://git.kernel.org/?p=linux/kernel/git/axboe/linux-2.6-block.git;a=commitdiff;h=d6beb57f48231f5c012fb7d55b369bc0af6b0c41
>
> The sg chaining patchset adds __use_sg to save the length of sg list
> before dma mapping. The sg chaining patchset also uses sglist_len but
> we can live without it. So let's remove sglist_len since we can add
> something to scsi_cmnd structure only when we definitely need to do.
>
> Now the sg chaining provides a way to decrease memory consumption and
> doesn't add anything to scsi_cmnd structure.
>
> James, do you want to change more about the sg chaining's scsi_lib.c?
Looks good to me!
--
Jens Axboe
prev parent reply other threads:[~2007-09-06 12:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-06 8:19 [PATCH] remove sglist_len FUJITA Tomonori
2007-09-06 12:25 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070906122502.GA5341@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=James.Bottomley@SteelEye.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-scsi@vger.kernel.org \
--cc=tomof@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox