Re: [PATCH 2/5] Refactoring scsi_error to facilitate in synchronous REQUEST_SENSE

[Christoph Hellwig <hch@infradead.org>]

> +void scsi_eh_prep_cmnd(struct scsi_cmnd *scmd,
> +	struct scsi_eh_save_cmnd_info *sesci, unsigned char *cmnd,
> +	int cmnd_size, int copy_sense)

I think just struct "struct scsi_eh_save *save" is descriptive enough and
almost fits on a line as well..  Also continuation of the prototype
is indented by two tabs normally.

> +struct scsi_eh_save_cmnd_info {
> +	int old_result;
> +	enum dma_data_direction old_data_direction;
> +	unsigned char old_cmd_len;
> +	unsigned char old_cmnd[MAX_COMMAND_SIZE];
> +	
> +	void* old_buffer;

	void *old_buffer;

> +	unsigned old_bufflen;
> +	unsigned short old_use_sg;
> +	int old_resid;
> +
> +	struct scatterlist sense_sgl;
> +};

I think you can kill the old prefixes in the struct, they're saved
per defintion.

Except for these cosmetic details the patch looks fine to me,
thanks a lot!