public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
	James Bottomley <James.Bottomley@SteelEye.com>,
	Christoph Hellwig <hch@infradead.org>,
	Hannes Reinecke <hare@suse.de>
Subject: Re: switch sdev sysfs attributes to default attributes
Date: Thu, 13 Sep 2007 14:29:25 +0100	[thread overview]
Message-ID: <20070913132925.GA30622@infradead.org> (raw)
In-Reply-To: <1189522814.4564.12.camel@lov.localdomain>

On Tue, Sep 11, 2007 at 05:00:14PM +0200, Kay Sievers wrote:
> From: Kay Sievers <kay.sievers@vrfy.org>
> Subject: [SCSI] switch sdev sysfs attributes to default attributes
> 
> This removes the unused sysfs attribute overwriting logic for most of
> the attributes, and plugs them into the driver core default attribute
> creation.
> 
> Without this patch, at the time of the events for the SCSI LUN's, there
> will be no sysfs files, because their creation is delayed until the sd
> driver has spun up the disks, which might take several seconds. It is the
> last WAIT_FOR_SYSFS rule in the default udev setup which can be removed
> with this change.

Looks good for to me.  How does sysfs react if some driver would add the
same attribute the core has already added?  If it give back a sane error
(and maybe even prints a message) then it's fine, otherwise we might have
to add some debug code to error out if a driver tries to add an existing
attribute because it sneaked through review or similar.


  reply	other threads:[~2007-09-13 13:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-11 15:00 switch sdev sysfs attributes to default attributes Kay Sievers
2007-09-13 13:29 ` Christoph Hellwig [this message]
2007-09-13 21:27   ` Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070913132925.GA30622@infradead.org \
    --to=hch@infradead.org \
    --cc=James.Bottomley@SteelEye.com \
    --cc=hare@suse.de \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox