From: Christoph Hellwig <hch@infradead.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
linux-scsi@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
achim_leubner@adaptec.com,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/4] more gdth patches for your amusement
Date: Tue, 25 Sep 2007 09:20:27 +0100 [thread overview]
Message-ID: <20070925082027.GA9587@infradead.org> (raw)
In-Reply-To: <46F85578.70503@garzik.org>
On Mon, Sep 24, 2007 at 08:25:28PM -0400, Jeff Garzik wrote:
> >OK, we've had these competing patch sets floating around for two months
> >now. Christoph and Jeff, can we get agreement on which is going in?
>
> Well, my opinion is
>
> 1) When judging by total amount of positive improvement, Christoph's
> patches are superior -- he has more overall cleanups than I do.
>
> 2) When judging by likelihood of inducing breakage, I feel my changes
> are superior. My gdth changes tightly adhere to the
> equivalent-transformation method of shuffing code around, enabling
> further improvements. IOW, I resisted the urge to make cleanups and fix
> insignificant, pre-existing bugs during the transformations.
>
> 3) I am utterly unmotivated to merge the two patchsets. Someone should
> make an executive decision, pull one patchset, and drop the other. My
> coding "mood" has swung from cleaning up code to writing new SAS drivers :)
Go ahead with your patches as I don't have time working on mine right now.
I'll port them ontop of your patches when I get time for it.
next prev parent reply other threads:[~2007-09-25 8:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-21 20:34 [PATCH 0/4] more gdth patches for your amusement Jeff Garzik
2007-07-21 20:34 ` [PATCH 1/4] gdth: kill gdth_{read,write}[bwl] wrappers Jeff Garzik
2007-07-21 20:35 ` [PATCH 2/4] gdth: Move probe-time error handling code to end of each function Jeff Garzik
2007-07-21 20:35 ` [PATCH 3/4] gdth: make some virt ctrlr code common; shuffle SHT members Jeff Garzik
2007-07-21 20:36 ` [PATCH 4/4] gdth: convert to modern SCSI host alloc/scan Jeff Garzik
2007-07-21 20:38 ` [PATCH 0/4] more gdth patches for your amusement Jeff Garzik
2007-09-15 14:12 ` James Bottomley
2007-09-25 0:25 ` Jeff Garzik
2007-09-25 8:20 ` Christoph Hellwig [this message]
2007-09-25 9:51 ` Boaz Harrosh
2007-09-25 11:56 ` Matthew Wilcox
2007-09-25 12:17 ` Boaz Harrosh
2007-09-25 12:22 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070925082027.GA9587@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=achim_leubner@adaptec.com \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).