From: Matthew Wilcox <matthew@wil.cx>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Matthew Wilcox <willy@linux.intel.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Get rid of scsi_cmnd->done
Date: Tue, 25 Sep 2007 11:09:17 -0600 [thread overview]
Message-ID: <20070925170917.GW10625@parisc-linux.org> (raw)
In-Reply-To: <46F93FC5.6060502@panasas.com>
On Tue, Sep 25, 2007 at 07:05:09PM +0200, Boaz Harrosh wrote:
> > @@ -694,7 +702,13 @@ void scsi_finish_command(struct scsi_cmnd *cmd)
> > "Notifying upper driver of completion "
> > "(result %x)\n", cmd->result));
> >
> > - cmd->done(cmd);
> > + good_bytes = cmd->request_bufflen;
> Please use scsi_bufflen(cmd) this file was already converted to
> accessors.
Ah; I was basing this on linus + scsi-misc. I guess scsi_lib hadn't
been converted because I just took the code from there.
> Thanks otherwise looks very good
Thank you for the review!
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-09-25 17:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 16:42 Remove ->done from scsi_cmnd Matthew Wilcox
2007-09-25 16:42 ` [PATCH] Fix mistaken uses of ->done Matthew Wilcox
2007-09-25 16:42 ` [PATCH] pluto: Don't abuse ->done for internal commands Matthew Wilcox
2007-09-25 16:42 ` [PATCH] gdth: Stop abusing " Matthew Wilcox
2007-09-25 17:30 ` Boaz Harrosh
2007-09-25 17:33 ` Matthew Wilcox
2007-09-25 16:42 ` [PATCH] Get rid of scsi_cmnd->done Matthew Wilcox
2007-09-25 17:05 ` Boaz Harrosh
2007-09-25 17:09 ` Matthew Wilcox [this message]
2007-09-26 19:54 ` Remove ->done from scsi_cmnd Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070925170917.GW10625@parisc-linux.org \
--to=matthew@wil.cx \
--cc=bharrosh@panasas.com \
--cc=linux-scsi@vger.kernel.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox