From: Matthew Wilcox <matthew@wil.cx>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Matthew Wilcox <willy@linux.intel.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] gdth: Stop abusing ->done for internal commands
Date: Tue, 25 Sep 2007 11:33:37 -0600 [thread overview]
Message-ID: <20070925173337.GX10625@parisc-linux.org> (raw)
In-Reply-To: <46F945B5.2030305@panasas.com>
On Tue, Sep 25, 2007 at 07:30:29PM +0200, Boaz Harrosh wrote:
> OK This is on top of the first patch that I will take care of,
> right? (http://www.spinics.net/lists/linux-scsi/msg19470.html)
That's right.
> Here 2 it will not merge with my patchset. So I'll take it off your hands
> and rebase it to mine.
Wonderful. Again, I don't care about this driver, just want it to not
break (more than it's already broken).
> In my patchset I have introduced a gdth_cmnd_priv. That is associated
> with every command and is put on cmnd->host_scribble, I than moved lots
> of abused Scp and other members to that new structure. I also put a
> simple boolean that states that these are Internal commands. So what
> is left of this patch is the:
> - scp->done = gdth_scsi_done;
> I will add that one line removal to your previous patch.
Excellent. Makes perfect sense.
> > Ah; I was basing this on linus + scsi-misc. I guess scsi_lib hadn't
> > been converted because I just took the code from there.
> Yes scsi_lib was not converted, but scsi.c was.
OK. I've converted that in my tree now, and fixed a small whitespace
error I introduced. I'll wait for more comments before posting a
replacement patch.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-09-25 17:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 16:42 Remove ->done from scsi_cmnd Matthew Wilcox
2007-09-25 16:42 ` [PATCH] Fix mistaken uses of ->done Matthew Wilcox
2007-09-25 16:42 ` [PATCH] pluto: Don't abuse ->done for internal commands Matthew Wilcox
2007-09-25 16:42 ` [PATCH] gdth: Stop abusing " Matthew Wilcox
2007-09-25 17:30 ` Boaz Harrosh
2007-09-25 17:33 ` Matthew Wilcox [this message]
2007-09-25 16:42 ` [PATCH] Get rid of scsi_cmnd->done Matthew Wilcox
2007-09-25 17:05 ` Boaz Harrosh
2007-09-25 17:09 ` Matthew Wilcox
2007-09-26 19:54 ` Remove ->done from scsi_cmnd Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070925173337.GX10625@parisc-linux.org \
--to=matthew@wil.cx \
--cc=bharrosh@panasas.com \
--cc=linux-scsi@vger.kernel.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox