From: Greg KH <greg@kroah.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
James Bottomley <James.Bottomley@steeleye.com>,
linux-usb-devel@lists.sourceforge.net,
linux-scsi@vger.kernel.org
Subject: Re: [linux-usb-devel] question on flushing buffers and spinning down disk
Date: Fri, 28 Sep 2007 12:33:04 -0700 [thread overview]
Message-ID: <20070928193304.GG8385@kroah.com> (raw)
In-Reply-To: <200709280902.45557.oliver@neukum.org>
On Fri, Sep 28, 2007 at 09:02:45AM +0200, Oliver Neukum wrote:
> Am Freitag 28 September 2007 schrieb Greg KH:
> > On Tue, Sep 25, 2007 at 05:11:00PM +0200, Oliver Neukum wrote:
> > >
> > > PS: Whoever designed klists is suffering from a case of overengineeringosis.
> >
> > No objection from me there. ?If you can think of a way to do list
> > traversal without taking locks, please, feel free to redo the whole
> > klist stuff.
>
> No, I just was happy to be able to avoid using them.
>
> But it is not just overengineered, it is also underengineered:
>
> int bus_for_each_dev(struct bus_type * bus, struct device * start,
> void * data, int (*fn)(struct device *, void *))
>
> An interface should be designed to note where it fails, thus:
>
> int bus_for_each_dev(struct bus_type * bus, struct device ** current,
> void * data, int (*fn)(struct device *, void *))
You know that patches are always gladly accepted :)
thanks,
greg k-h
next prev parent reply other threads:[~2007-09-28 19:58 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 8:32 question on flushing buffers and spinning down disk Oliver Neukum
2007-09-18 14:01 ` James Bottomley
2007-09-18 14:15 ` Oliver Neukum
2007-09-18 14:26 ` James Bottomley
2007-09-24 10:33 ` Oliver Neukum
2007-09-24 14:38 ` Alan Stern
2007-09-24 15:21 ` Oliver Neukum
2007-09-24 15:34 ` Alan Stern
2007-09-24 16:47 ` Oliver Neukum
2007-09-24 17:10 ` Alan Stern
2007-09-24 19:16 ` [linux-usb-devel] " Oliver Neukum
2007-09-24 19:39 ` Alan Stern
2007-09-24 20:00 ` [linux-usb-devel] " Oliver Neukum
2007-09-25 14:13 ` Alan Stern
2007-09-25 15:11 ` Oliver Neukum
2007-09-28 4:27 ` Greg KH
2007-09-28 7:02 ` Oliver Neukum
2007-09-28 19:33 ` Greg KH [this message]
2007-09-25 7:50 ` Oliver Neukum
2007-09-25 15:03 ` Alan Stern
2007-09-27 11:40 ` Oliver Neukum
2007-09-27 16:01 ` Alan Stern
2007-09-27 18:12 ` Oliver Neukum
2007-09-27 19:07 ` [linux-usb-devel] " Alan Stern
2007-09-27 19:26 ` Oliver Neukum
2007-09-27 20:26 ` Alan Stern
2007-09-27 20:54 ` Steve Calfee
2007-09-27 21:16 ` Alan Stern
2007-09-27 21:37 ` U. George
2007-09-28 8:17 ` [linux-usb-devel] " Oliver Neukum
2007-09-28 15:01 ` Alan Stern
2007-09-28 8:22 ` [linux-usb-devel] " Oliver Neukum
2007-09-28 21:11 ` Alan Stern
2007-09-28 21:47 ` Oliver Neukum
2007-09-29 15:56 ` Alan Stern
2007-09-29 16:12 ` [linux-usb-devel] " Oliver Neukum
2007-09-28 9:04 ` Oliver Neukum
2007-09-28 15:07 ` Alan Stern
2007-09-28 21:33 ` [linux-usb-devel] " Oliver Neukum
2007-09-29 16:38 ` Alan Stern
2007-09-29 17:52 ` Oliver Neukum
2007-09-29 19:06 ` Alan Stern
2007-09-29 20:06 ` Oliver Neukum
2007-09-29 20:56 ` Alan Stern
2007-09-29 21:03 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070928193304.GG8385@kroah.com \
--to=greg@kroah.com \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=oliver@neukum.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox