From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] aic94xx: fix SMP request DMA direction
Date: Fri, 28 Sep 2007 16:55:34 -0700 [thread overview]
Message-ID: <20070928235534.GC22855@tree.beaverton.ibm.com> (raw)
In-Reply-To: <20070928023341.GA10750@havoc.gtf.org>
On Thu, Sep 27, 2007 at 10:33:41PM -0400, Jeff Garzik wrote:
>
> Unless I'm missing something, the SMP request goes /to/ the PCI device :)
>
> Signed-off-by: Jeff Garzik <jeff@garzik.org>
ACK; builds ok and SMP commands seem to work ok (not that they didn't
before).
--Darrick
> ---
> drivers/scsi/aic94xx/aic94xx_task.c | 4 -
> 2 files changed, 83 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/scsi/aic94xx/aic94xx_task.c b/drivers/scsi/aic94xx/aic94xx_task.c
> index d5d8cab..ab13824 100644
> --- a/drivers/scsi/aic94xx/aic94xx_task.c
> +++ b/drivers/scsi/aic94xx/aic94xx_task.c
> @@ -451,7 +451,7 @@ static int asd_build_smp_ascb(struct asd_ascb *ascb, struct sas_task *task,
> struct scb *scb;
>
> pci_map_sg(asd_ha->pcidev, &task->smp_task.smp_req, 1,
> - PCI_DMA_FROMDEVICE);
> + PCI_DMA_TODEVICE);
> pci_map_sg(asd_ha->pcidev, &task->smp_task.smp_resp, 1,
> PCI_DMA_FROMDEVICE);
>
> @@ -486,7 +486,7 @@ static void asd_unbuild_smp_ascb(struct asd_ascb *a)
>
> BUG_ON(!task);
> pci_unmap_sg(a->ha->pcidev, &task->smp_task.smp_req, 1,
> - PCI_DMA_FROMDEVICE);
> + PCI_DMA_TODEVICE);
> pci_unmap_sg(a->ha->pcidev, &task->smp_task.smp_resp, 1,
> PCI_DMA_FROMDEVICE);
> }
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-09-28 23:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-28 2:33 [PATCH] aic94xx: fix SMP request DMA direction Jeff Garzik
2007-09-28 23:55 ` Darrick J. Wong [this message]
2007-09-29 6:22 ` Muli Ben-Yehuda
2007-09-29 6:25 ` Jeff Garzik
2007-09-30 7:13 ` Darrick J. Wong
2007-09-30 7:26 ` Muli Ben-Yehuda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070928235534.GC22855@tree.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=jeff@garzik.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox