Re: [PATCH] aic94xx: fix SMP request DMA direction

Jeff Garzik
2007-09-29T06:25:37Z

Muli Ben-Yehuda wrote:
> On Fri, Sep 28, 2007 at 04:55:34PM -0700, Darrick J. Wong wrote:
>> On Thu, Sep 27, 2007 at 10:33:41PM -0400, Jeff Garzik wrote:
>>> Unless I'm missing something, the SMP request goes /to/ the PCI device :)
>>>
>>> Signed-off-by: Jeff Garzik <jeff@garzik.org>
>> ACK; builds ok and SMP commands seem to work ok (not that they
>> didn't before).
>
> Could this explain some weirdness we were seeing with aic94xx and
> Calgary/CalIOC2 enabled, or are SMP commands not likely to be used in
> normal operation? We map the IOMMU entries differently for FROMDEVICE
> (RW) and TODEVICE(RO).

SMP == scsi management == not used during normal data transfer.

It could certainly explain flakiness if you have expanders, though

Jeff