From: David Miller <davem@davemloft.net>
To: jeff@garzik.org
Cc: matthew@wil.cx, sparclinux@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: slave_configure for qlogicpti
Date: Sun, 30 Sep 2007 18:24:12 -0700 (PDT) [thread overview]
Message-ID: <20070930.182412.08350831.davem@davemloft.net> (raw)
In-Reply-To: <470044DD.40100@garzik.org>
From: Jeff Garzik <jeff@garzik.org>
Date: Sun, 30 Sep 2007 20:52:45 -0400
> David Miller wrote:
> > It compiles :-) You deleted the only uses of scsi_rbuf_{get,put}()
> > so you can kill those off too.
>
>
> Seeing as how they are exact duplicates of libata's
> ata_scsi_rbuf_{get,put}, I wonder how they got there in the first place
> (rather than becoming common code), and I wonder how many more copies
> are floating out there...
I bet: 1) they were common code in scsi_lib.c 2) qlogicpti and libata
became the only remaining users so 3) they got copied to those
two users verbatim anticipating that the qlogicpti usage would
eventually be deleted.
Interested parties can search the tree history to determine for
suer :-)
next prev parent reply other threads:[~2007-10-01 1:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 12:46 slave_configure for qlogicpti Matthew Wilcox
2007-10-01 0:29 ` David Miller
2007-10-01 0:52 ` Jeff Garzik
2007-10-01 1:24 ` David Miller [this message]
2007-10-01 12:22 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070930.182412.08350831.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox