public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Muli Ben-Yehuda <muli@il.ibm.com>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: Jeff Garzik <jeff@garzik.org>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] aic94xx: fix SMP request DMA direction
Date: Sun, 30 Sep 2007 09:26:52 +0200	[thread overview]
Message-ID: <20070930072652.GG4239@rhun.haifa.ibm.com> (raw)
In-Reply-To: <20070930071355.GC21125@tree.beaverton.ibm.com>

On Sun, Sep 30, 2007 at 12:13:55AM -0700, Darrick J. Wong wrote:

> Actually, SMP commands are used during device discovery to find
> things attached to expanders, so it seems likely that "it blows up
> almost immediately after loading the module" symptoms are a result
> of this bug.
> 
> That said, the bug that Jeff fixed resulted in extra permissions
> (+w) being set for the SMP request buffer, so that's probably why
> I've never seen any problems manifesting on x260/x3800 systems.
> 
> (Unless the CalIOC2 has a write only mode?)

It does (you can turn on each of the R and W bits in the TCE entry
seperately) but we don't make use of it - we set it to either none, RO
or RW.

Cheers,
Muli

      reply	other threads:[~2007-09-30  7:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-28  2:33 [PATCH] aic94xx: fix SMP request DMA direction Jeff Garzik
2007-09-28 23:55 ` Darrick J. Wong
2007-09-29  6:22   ` Muli Ben-Yehuda
2007-09-29  6:25     ` Jeff Garzik
2007-09-30  7:13       ` Darrick J. Wong
2007-09-30  7:26         ` Muli Ben-Yehuda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070930072652.GG4239@rhun.haifa.ibm.com \
    --to=muli@il.ibm.com \
    --cc=djwong@us.ibm.com \
    --cc=jeff@garzik.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox