[patch 11/17] Fix section mismatch in the Adaptec DPT SCSI Raid driver

[patch 11/17] Fix section mismatch in the Adaptec DPT SCSI Raid driver

[akpm]

From: Joe Korty <joe.korty@ccur.com>

Fix section mismatch in the Adaptec DPT SCSI Raid driver.

WARNING: vmlinux.o(.init.text+0x1fcd2): Section mismatch:
	reference to .exit.text:adpt_exit (between 'adpt_init' and 'ahc_linux_init')

This warning is due to adaptec device detection calling the exit routine on
failure to properly register the adaptec device.

The exit routine + call was added on July 30 by

	Commit: 55d9fcf57ba5ec427544fca7abc335cf3da78160
	Author: Matthew Wilcox
	Subject: [SCSI] dpt_i2o: convert to SCSI hotplug model.

Mathew: isn't a module exit routine a little too strong to be calling on the
failure of a single device?  Module exit implies that other, non-failing
adaptec raid devices will also get shut down.  

Signed-off-by: Joe Korty <joe.korty@ccur.com>
Cc: <aacraid@adaptec.com>
Cc: James Bottomley <James.Bottomley@steeleye.com>
Cc: Matthew Wilcox <willy@debian.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/scsi/dpt_i2o.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/scsi/dpt_i2o.c~fix-section-mismatch-in-the-adaptec-dpt-scsi-raid-driver drivers/scsi/dpt_i2o.c
--- a/drivers/scsi/dpt_i2o.c~fix-section-mismatch-in-the-adaptec-dpt-scsi-raid-driver
+++ a/drivers/scsi/dpt_i2o.c
@@ -3346,7 +3346,7 @@ static int __init adpt_init(void)
 	return count > 0 ? 0 : -ENODEV;
 }
 
-static void __exit adpt_exit(void)
+static void adpt_exit(void)
 {
 	while (hba_chain)
 		adpt_release(hba_chain);
_

Re: [patch 11/17] Fix section mismatch in the Adaptec DPT SCSI Raid driver

[Matthew Wilcox]

On Tue, Oct 02, 2007 at 02:38:08PM -0700, akpm@linux-foundation.org wrote:
> From: Joe Korty <joe.korty@ccur.com>
> 
> Fix section mismatch in the Adaptec DPT SCSI Raid driver.

Acked-by: Matthew Wilcox <willy@linux.intel.com>

> Mathew: isn't a module exit routine a little too strong to be calling on the
> failure of a single device?  Module exit implies that other, non-failing
> adaptec raid devices will also get shut down.  

It's what the original driver did.  Feel free to propose a better
alternative ;-)

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."