public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 12/17] advansys printk fix
@ 2007-10-02 21:38 akpm
  2007-10-02 21:52 ` Matthew Wilcox
  0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2007-10-02 21:38 UTC (permalink / raw)
  To: James.Bottomley; +Cc: linux-scsi, akpm

From: Andrew Morton <akpm@linux-foundation.org>

Fix this:

drivers/scsi/advansys.c: In function 'advansys_board_found':
drivers/scsi/advansys.c:16320: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'resource_size_t'

and clean the code up a little.

Cc: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/scsi/advansys.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff -puN drivers/scsi/advansys.c~advansys-printk-fix drivers/scsi/advansys.c
--- a/drivers/scsi/advansys.c~advansys-printk-fix
+++ a/drivers/scsi/advansys.c
@@ -14254,10 +14254,11 @@ advansys_board_found(int iop, struct dev
 		boardp->ioremap_addr = ioremap(pci_resource_start(pdev, 1),
 					       boardp->asc_n_io_port);
 		if (!boardp->ioremap_addr) {
-			ASC_PRINT3
-			    ("advansys_board_found: board %d: ioremap(%x, %d) returned NULL\n",
-			     boardp->id, pci_resource_start(pdev, 1),
-			     boardp->asc_n_io_port);
+			ASC_PRINT3("advansys_board_found: board %d: "
+				"ioremap(%llx, %d) returned NULL\n",
+				boardp->id,
+				(unsigned long long)pci_resource_start(pdev, 1),
+				boardp->asc_n_io_port);
 			goto err_shost;
 		}
 		adv_dvc_varp->iop_base = (AdvPortAddr)boardp->ioremap_addr
_

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 12/17] advansys printk fix
  2007-10-02 21:38 [patch 12/17] advansys printk fix akpm
@ 2007-10-02 21:52 ` Matthew Wilcox
  0 siblings, 0 replies; 2+ messages in thread
From: Matthew Wilcox @ 2007-10-02 21:52 UTC (permalink / raw)
  To: akpm; +Cc: James.Bottomley, linux-scsi

On Tue, Oct 02, 2007 at 02:38:09PM -0700, akpm@linux-foundation.org wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> 
> Fix this:
> 
> drivers/scsi/advansys.c: In function 'advansys_board_found':
> drivers/scsi/advansys.c:16320: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'resource_size_t'
> 
> and clean the code up a little.

This'll conflict with a few of the patches in my tree; I have fixed the
warning ... James, any intent to merge the most recent series of patches
I sent?

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-10-02 21:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-02 21:38 [patch 12/17] advansys printk fix akpm
2007-10-02 21:52 ` Matthew Wilcox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox