[patch 01/17] git-scsi-misc: arcmsr build fix

[patch 01/17] git-scsi-misc: arcmsr build fix

[akpm]

From: Andrew Morton <akpm@linux-foundation.org>

drivers/scsi/arcmsr/arcmsr_hba.c:129: error: 'arcmsr_pci_error_detected' undeclared here (not in a function)
drivers/scsi/arcmsr/arcmsr_hba.c:130: error: 'arcmsr_pci_slot_reset' undeclared here (not in a function)

Cc: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/scsi/arcmsr/arcmsr_hba.c |    4 ++++
 1 file changed, 4 insertions(+)

diff -puN drivers/scsi/arcmsr/arcmsr_hba.c~git-scsi-misc-arcmsr-build-fix drivers/scsi/arcmsr/arcmsr_hba.c
--- a/drivers/scsi/arcmsr/arcmsr_hba.c~git-scsi-misc-arcmsr-build-fix
+++ a/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -125,6 +125,10 @@ static struct scsi_host_template arcmsr_
 	.shost_attrs		= arcmsr_host_attrs,
 };
 #ifdef CONFIG_SCSI_ARCMSR_AER
+static pci_ers_result_t arcmsr_pci_slot_reset(struct pci_dev *pdev);
+static pci_ers_result_t arcmsr_pci_error_detected(struct pci_dev *pdev,
+						pci_channel_state_t state);
+
 static struct pci_error_handlers arcmsr_pci_error_handlers = {
 	.error_detected		= arcmsr_pci_error_detected,
 	.slot_reset		= arcmsr_pci_slot_reset,
_

Re: [patch 01/17] git-scsi-misc: arcmsr build fix

[James Bottomley]

On Tue, 2007-10-02 at 14:37 -0700, akpm@linux-foundation.org wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> 
> drivers/scsi/arcmsr/arcmsr_hba.c:129: error: 'arcmsr_pci_error_detected' undeclared here (not in a function)
> drivers/scsi/arcmsr/arcmsr_hba.c:130: error: 'arcmsr_pci_slot_reset' undeclared here (not in a function)
> 
> Cc: James Bottomley <James.Bottomley@steeleye.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Heh, snap:

http://marc.info/?l=linux-scsi&m=119081791117423&w=2

James

Re: [patch 01/17] git-scsi-misc: arcmsr build fix

[Andrew Morton]

I sent seventeen patches and only one was applied.

Please either merge the others or give them a nack-with-reasons or specify
how they need to be altered.

Please do not just ignore them.  This creates additional ongoing
maintenance work for myself.

Thanks.

Re: [patch 01/17] git-scsi-misc: arcmsr build fix

[James Bottomley]

On Fri, 2007-10-05 at 12:07 -0700, Andrew Morton wrote:
> I sent seventeen patches and only one was applied.
> 
> Please either merge the others or give them a nack-with-reasons or specify
> how they need to be altered.
> 
> Please do not just ignore them.  This creates additional ongoing
> maintenance work for myself.

Actually, none were applied ... you just got a fortuitous match with one
of Matthew's advansys patches, like he said you would.  Yours are in the
queue behind the gdth patch set which is currently causing me merge
problems.  Once I get that sorted out, I'll likely apply all of yours
bar the ones I already replied about.

James

Re: [patch 01/17] git-scsi-misc: arcmsr build fix

[Andrew Morton]

On Fri, 05 Oct 2007 16:49:22 -0400
James Bottomley <James.Bottomley@SteelEye.com> wrote:

> On Fri, 2007-10-05 at 12:07 -0700, Andrew Morton wrote:
> > I sent seventeen patches and only one was applied.
> > 
> > Please either merge the others or give them a nack-with-reasons or specify
> > how they need to be altered.
> > 
> > Please do not just ignore them.  This creates additional ongoing
> > maintenance work for myself.
> 
> Actually, none were applied ...

ok, mpt-fusion-shut-up-uninitialized-variable.patch arrive in your tree via
some other route and confused me.

> you just got a fortuitous match with one
> of Matthew's advansys patches, like he said you would.  Yours are in the
> queue behind the gdth patch set which is currently causing me merge
> problems.  Once I get that sorted out, I'll likely apply all of yours
> bar the ones I already replied about.

OK, thanks.

wrt the ones you already replied about: I'm unsure which those are so can
you please re-reply?  I'd prefer to drop marginal stuff rather than having
it hang around for ever.

Thanks.

Re: [patch 01/17] git-scsi-misc: arcmsr build fix

[James Bottomley]

On Fri, 2007-10-05 at 14:04 -0700, Andrew Morton wrote:
> On Fri, 05 Oct 2007 16:49:22 -0400
> James Bottomley <James.Bottomley@SteelEye.com> wrote:
> 
> > On Fri, 2007-10-05 at 12:07 -0700, Andrew Morton wrote:
> > > I sent seventeen patches and only one was applied.
> > > 
> > > Please either merge the others or give them a nack-with-reasons or specify
> > > how they need to be altered.
> > > 
> > > Please do not just ignore them.  This creates additional ongoing
> > > maintenance work for myself.
> > 
> > Actually, none were applied ...
> 
> ok, mpt-fusion-shut-up-uninitialized-variable.patch arrive in your tree via
> some other route and confused me.
> 
> > you just got a fortuitous match with one
> > of Matthew's advansys patches, like he said you would.  Yours are in the
> > queue behind the gdth patch set which is currently causing me merge
> > problems.  Once I get that sorted out, I'll likely apply all of yours
> > bar the ones I already replied about.
> 
> OK, thanks.
> 
> wrt the ones you already replied about: I'm unsure which those are so can
> you please re-reply?  I'd prefer to drop marginal stuff rather than having
> it hang around for ever.

It was just the aic7xxx one (8/17).  I'll resend.

James