From: Matthew Wilcox <matthew@wil.cx>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-scsi@vger.kernel.org, Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH 14/17] sym53c8xx: Get rid of IRQ_FMT and IRQ_PRM
Date: Tue, 9 Oct 2007 09:44:14 -0600 [thread overview]
Message-ID: <20071009154413.GH13842@parisc-linux.org> (raw)
In-Reply-To: <470B9FB2.9010300@garzik.org>
On Tue, Oct 09, 2007 at 11:35:14AM -0400, Jeff Garzik wrote:
> Not true. The original code used 'int irq', and the printf format was
> correct as a result.
>
> You changed the code to use 'unsigned int irq' as found in struct
> pci_dev, without changing IRQ_FMT as needed.
>
> If you wanted to avoid the regression another way, I suppose patch #1
> should update IRQ_FMT to use "%u", and patch #14 should move the "%u"
> use to its caller.
What do you think the regression is, exactly?
The *only* difference in how vsnprintf handles %d vs %u is the sign bit.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-10-09 15:44 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-05 19:54 [PATCH 1/17] sym53c8xx: Work around 53c896 erratum Matthew Wilcox
2007-10-05 19:54 ` [PATCH 2/17] sym53c8xx: Use pci_dev irq number Matthew Wilcox
2007-10-05 20:51 ` Jeff Garzik
2007-10-05 19:55 ` [PATCH 3/17] sym53c8xx: Remove data_mapping and data_mapped Matthew Wilcox
2007-10-05 20:52 ` Jeff Garzik
2007-10-05 19:55 ` [PATCH 4/17] sym53c8xx: Remove unnecessary check in queuecommand Matthew Wilcox
2007-10-05 19:55 ` [PATCH 5/17] sym53c8xx: Don't disable interrupts in the interrupt handler Matthew Wilcox
2007-10-05 19:55 ` [PATCH 6/17] sym53c8xx: Stop overriding scsi_done Matthew Wilcox
2007-10-05 19:55 ` [PATCH 7/17] sym53c8xx: PCI Error Recovery support Matthew Wilcox
2007-10-05 20:54 ` Jeff Garzik
2007-10-05 19:55 ` [PATCH 8/17] sym53c8xx: Use pdev->revision Matthew Wilcox
2007-10-05 19:55 ` [PATCH 9/17] sym53c8xx: Remove ->device_id Matthew Wilcox
2007-10-05 19:55 ` [PATCH 10/17] sym53c8xx: Remove io_ws, mmio_ws and ram_ws elements Matthew Wilcox
2007-10-05 20:55 ` Jeff Garzik
2007-10-05 19:55 ` [PATCH 11/17] sym53c8xx: Remove tag_ctrl module parameter Matthew Wilcox
2007-10-05 20:56 ` Jeff Garzik
2007-10-09 15:35 ` Matthew Wilcox
2007-10-05 19:55 ` [PATCH 12/17] sym53c8xx: Simplify DAC DMA handling Matthew Wilcox
2007-10-05 19:55 ` [PATCH 13/17] sym53c8xx: Use scmd_printk where appropriate Matthew Wilcox
2007-10-05 20:59 ` Jeff Garzik
2007-10-05 19:55 ` [PATCH 14/17] sym53c8xx: Get rid of IRQ_FMT and IRQ_PRM Matthew Wilcox
2007-10-05 20:59 ` Jeff Garzik
2007-10-09 15:28 ` Matthew Wilcox
2007-10-09 15:35 ` Jeff Garzik
2007-10-09 15:44 ` Matthew Wilcox [this message]
2007-10-09 15:47 ` Jeff Garzik
2007-10-05 19:55 ` [PATCH 15/17] sym53c8xx: Make interrupt handler capable of returning IRQ_NONE Matthew Wilcox
2007-10-05 21:04 ` Jeff Garzik
2007-10-05 19:55 ` [PATCH 16/17] sym53c8xx: Remove pci_dev pointer from sym_shcb Matthew Wilcox
2007-10-05 21:07 ` Jeff Garzik
2007-10-09 15:27 ` Matthew Wilcox
2007-10-05 19:55 ` [PATCH 17/17] sym53c8xx: Remove sym_xpt_async_sent_bdr Matthew Wilcox
2007-10-05 21:07 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071009154413.GH13842@parisc-linux.org \
--to=matthew@wil.cx \
--cc=jeff@garzik.org \
--cc=linux-scsi@vger.kernel.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).