Build Failure (Was Re: 2.6.23-mm1)

Build Failure (Was Re: 2.6.23-mm1)

[Dhaval Giani]

On Thu, Oct 11, 2007 at 09:31:26PM -0700, Andrew Morton wrote:
> 
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23/2.6.23-mm1/
> 

Hi Andrew

My compile just failed with 

drivers/scsi/gdth.c: In function ‘gdth_search_dev’:
drivers/scsi/gdth.c:646: warning: ‘pci_find_device’ is deprecated
(declared at include/linux/pci.h:482)
drivers/scsi/gdth.c: In function ‘gdth_init_isa’:
drivers/scsi/gdth.c:857: error: ‘gdth_irq_tab’ undeclared (first use in
this function)
drivers/scsi/gdth.c:857: error: (Each undeclared identifier is reported
only once
drivers/scsi/gdth.c:857: error: for each function it appears in.)
drivers/scsi/gdth.c: In function ‘gdth_copy_internal_data’:
drivers/scsi/gdth.c:2362: warning: unused variable ‘sg’
make[2]: *** [drivers/scsi/gdth.o] Error 1
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2
[dhaval@gondor linux-2.6.23]$

Looking into the code I notice that gdth_irq_tab is not declared with
CONFIG_ISA=y and !CONFIG_EISA.

The values seem to be same in 2.6.23 (I am not sure why it has been put
with #ifdefs in -mm) so I have just modified the #ifdef to take care of
CONFIG_ISA as well.

(Compile tested only)

Thanks,

--

Signed-off-by: Dhaval Giani <dhaval@linux.vnet.ibm.com>


Index: linux-2.6.23/drivers/scsi/gdth.c
===================================================================
--- linux-2.6.23.orig/drivers/scsi/gdth.c	2007-10-12 14:07:28.000000000 +0530
+++ linux-2.6.23/drivers/scsi/gdth.c	2007-10-12 15:06:47.000000000 +0530
@@ -288,7 +288,7 @@ static struct timer_list gdth_timer;
 #ifdef CONFIG_ISA
 static unchar   gdth_drq_tab[4] = {5,6,7,7};            /* DRQ table */
 #endif
-#ifdef CONFIG_EISA
+#if defined(CONFIG_EISA) || defined(CONFIG_ISA)
 static unchar   gdth_irq_tab[6] = {0,10,11,12,14,0};    /* IRQ table */
 #endif
 static unchar   gdth_polling;                           /* polling if TRUE */

-- 
regards,
Dhaval
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

oops in lbmIODone, fails to boot [Re: 2.6.23-mm1]

[Mattia Dongili]

On Thu, Oct 11, 2007 at 09:31:26PM -0700, Andrew Morton wrote:
> 
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23/2.6.23-mm1/

Hey there!!
fails to boot here with this friendly oops:
http://oioio.altervista.org/linux/dsc01702.jpg

.config: http://oioio.altervista.org/linux/config-2.6.23-mm1-1

2.6.23-rc8-mm2 booted ok but had other problems I haven't reported yet
(no s2ram with mysql running and some net WARNING).
Let's see if .23-mm1 still has those first.

I'm adding Cc: linux-scsi

PS: I'll hardly be able to bisect in the next days... :P
-- 
mattia
:wq!

Re: oops in lbmIODone, fails to boot [Re: 2.6.23-mm1]

[Andrew Morton]

On Sat, 20 Oct 2007 13:57:54 +0900 Mattia Dongili <malattia@linux.it> wrote:

> On Thu, Oct 11, 2007 at 09:31:26PM -0700, Andrew Morton wrote:
> > 
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23/2.6.23-mm1/
> 
> Hey there!!
> fails to boot here with this friendly oops:
> http://oioio.altervista.org/linux/dsc01702.jpg
> 
> .config: http://oioio.altervista.org/linux/config-2.6.23-mm1-1
> 
> 2.6.23-rc8-mm2 booted ok but had other problems I haven't reported yet
> (no s2ram with mysql running and some net WARNING).
> Let's see if .23-mm1 still has those first.
> 
> I'm adding Cc: linux-scsi
> 
> PS: I'll hardly be able to bisect in the next days... :P

That looks like a Jens and Dave production to me.

Re: oops in lbmIODone, fails to boot [Re: 2.6.23-mm1]

[Dave Kleikamp]

On Fri, 2007-10-19 at 22:34 -0700, Andrew Morton wrote:
> On Sat, 20 Oct 2007 13:57:54 +0900 Mattia Dongili <malattia@linux.it> wrote:
> 
> > On Thu, Oct 11, 2007 at 09:31:26PM -0700, Andrew Morton wrote:
> > > 
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23/2.6.23-mm1/
> > 
> > Hey there!!
> > fails to boot here with this friendly oops:
> > http://oioio.altervista.org/linux/dsc01702.jpg
> > 
> > .config: http://oioio.altervista.org/linux/config-2.6.23-mm1-1
> > 
> > 2.6.23-rc8-mm2 booted ok but had other problems I haven't reported yet
> > (no s2ram with mysql running and some net WARNING).
> > Let's see if .23-mm1 still has those first.
> > 
> > I'm adding Cc: linux-scsi
> > 
> > PS: I'll hardly be able to bisect in the next days... :P
> 
> That looks like a Jens and Dave production to me.

Yes, and it's been fixed:
http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=8d8fe64237646fdd2c2de2722ec4189a5999119d

See also: http://lkml.org/lkml/2007/10/13/174

Thanks,
Shaggy
-- 
David Kleikamp
IBM Linux Technology Center

Re: oops in lbmIODone, fails to boot [Re: 2.6.23-mm1]

[Mattia Dongili]

On Sat, Oct 20, 2007 at 07:18:26AM -0500, Dave Kleikamp wrote:
> On Fri, 2007-10-19 at 22:34 -0700, Andrew Morton wrote:
> > On Sat, 20 Oct 2007 13:57:54 +0900 Mattia Dongili <malattia@linux.it> wrote:
> > 
> > > On Thu, Oct 11, 2007 at 09:31:26PM -0700, Andrew Morton wrote:
> > > > 
> > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23/2.6.23-mm1/
> > > 
> > > Hey there!!
> > > fails to boot here with this friendly oops:
> > > http://oioio.altervista.org/linux/dsc01702.jpg
> > > 
> > > .config: http://oioio.altervista.org/linux/config-2.6.23-mm1-1
> > > 
> > > 2.6.23-rc8-mm2 booted ok but had other problems I haven't reported yet
> > > (no s2ram with mysql running and some net WARNING).
> > > Let's see if .23-mm1 still has those first.
> > > 
> > > I'm adding Cc: linux-scsi
> > > 
> > > PS: I'll hardly be able to bisect in the next days... :P
> > 
> > That looks like a Jens and Dave production to me.
> 
> Yes, and it's been fixed:
> http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=8d8fe64237646fdd2c2de2722ec4189a5999119d

thanks this fixes it
-- 
mattia
:wq!